Run3-sim56 Extended biglib to include some of the applications using geant4core #29155
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29155/14108
|
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: BigProducts/Simulation @smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@smuzaffar Could you review this one? |
|
+core All the newly added packages [a] for BigProduct are only used by BigProduct/Simulation except SimG4Core/GFlash which is used by FastSimulation/Calorimetry too . #29183 cleans up this unneeded dependency. This PR can be merged without #29183 [a] |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
Hi David,
It includes some of the packages which are SimWatchers and are run along with the simulation step. Surely these are not in standard production. Also test beam simulations are not run in production applications and they are added. The idea was to include the packages which utilize simulation. Is it possible to disable biglib as a default and only used for production builds?
Sunanda
…________________________________
From: David Lange [notifications@github.com]
Sent: 27 August 2020 11:16
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run3-sim56 Extended biglib to include some of the applications using geant4core (#29155)
hi @bsunanda<https://github.com/bsunanda> @civanch<https://github.com/civanch> - could you motivate this change (belatedly)? It does not seem to impact production applications run by cms
I'm asking as it has pulled in root dictionaries
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOSZEMOOF3AOOGB3TX3SCYP5XANCNFSM4LEPES2Q>.
|
|
I understand what’s changed - What was the problem you ran into? Something doesn’t work without this change?
On Aug 27, 2020, at 2:58 PM, bsunanda <notifications@github.com<mailto:notifications@github.com>> wrote:
Hi David,
It includes some of the packages which are SimWatchers and are run along with the simulation step. Surely these are not in standard production. Also test beam simulations are not run in production applications and they are added. The idea was to include the packages which utilize simulation. Is it possible to disable biglib as a default and only used for production builds?
Sunanda
…________________________________
From: David Lange [notifications@github.com<mailto:notifications@github.com>]
Sent: 27 August 2020 11:16
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run3-sim56 Extended biglib to include some of the applications using geant4core (#29155)
hi @bsunanda<https://github.com/bsunanda> @civanch<https://github.com/civanch> - could you motivate this change (belatedly)? It does not seem to impact production applications run by cms
I'm asking as it has pulled in root dictionaries
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOSZEMOOF3AOOGB3TX3SCYP5XANCNFSM4LEPES2Q>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ5DZCWHE52PUW67OQDSCZKADANCNFSM4LEPES2Q>.
|
|
@davidlange6 Just to understand better, with
do you mean that root dictionaries get pulled in the biglib? Do you know which specific package(s) pulls in the dictionaries? |
|
Hi Matti, I am not sure - but could be Validation/Geometry Sybabda
…________________________________
From: Matti Kortelainen [notifications@github.com]
Sent: 27 August 2020 15:13
To: cms-sw/cmssw
Cc: Sunanda Banerjee; Mention
Subject: Re: [cms-sw/cmssw] Run3-sim56 Extended biglib to include some of the applications using geant4core (#29155)
@davidlange6<https://github.com/davidlange6> Just to understand better, with
I'm asking as it has pulled in root dictionaries
do you mean that root dictionaries get pulled in the biglib? Do you know which specific package(s) pulls in the dictionaries?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZORLMPGDIJLJDQZU5K3SCZLV7ANCNFSM4LEPES2Q>.
|
|
SimDataFormats/ValidationFormats.
On Aug 27, 2020, at 3:13 PM, Matti Kortelainen <notifications@github.com<mailto:notifications@github.com>> wrote:
@davidlange6<https://github.com/davidlange6> Just to understand better, with
I'm asking as it has pulled in root dictionaries
do you mean that root dictionaries get pulled in the biglib? Do you know which specific package(s) pulls in the dictionaries?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ63AKF5IJ6PAIO4M4TSCZLV7ANCNFSM4LEPES2Q>.
|
|
Oh, that one (didn't notice because of looking only Shahzad's list in #29155 (comment)), thanks. Perhaps |
|
On Aug 27, 2020, at 3:34 PM, Matti Kortelainen <notifications@github.com<mailto:notifications@github.com>> wrote:
Oh, that one (didn't notice because of looking only Shahzad's list in #29155 (comment)<#29155 (comment)>), thanks. Perhaps SimDataFormats/ValidationFormats could then be removed from the biglib?
I’m asking to understand the need for it - right.
Cheers-
David
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ5FOEBUNOUA4EHF5LLSCZOG5ANCNFSM4LEPES2Q>.
|
|
SimDataFormats/ValidationFormats was not added in this PR. It was at the end of the xml file - it is only pushed up so that the file names appear in alphabetic order. |
|
Ha - indeed, my mistake - its from 2014.
bsunanda@db28aa8#diff-a0c73eeab0fd144ac7699659dcbcb4da
I gather that the point is that if you want to use any library that is part of biglib then all things that depend on that library must be a part of biglib?
On Aug 27, 2020, at 3:52 PM, bsunanda <notifications@github.com> wrote:
SimDataFormats/ValidationFormats was not added in this PR. It was at the end of the xml file - it is only pushed up so that the file names appear in alphabetic order.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#29155 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ2AVVXPOWPTVQUGUYDSCZQLHANCNFSM4LEPES2Q>.
|
|
@davidlange6 , not all of its dependencies but only those where we link geant4. Basically all packages which depend on geant4 should end up in pluginSimulation. This is because pluginSimulation is linked against static geant4 which normal small libs are linked against shared geant4. If in a job we load both pluginSimulation and (lib|plugin)SomeThingLinkingSharedGeant4.so then there will be conflicting symbols and job will crash. |
|
ok, thanks - now I think I understand the mechanism. |
|
I'd propose that I remove the g4 dependency from SimDataFormats/ValidationFormats. It is just used for error checking, which can be moved to the plugin. |
|
sounds good to me |
|
Thanks, David, this would be correct.
Vladimir
…On Thu, 27 Aug 2020, Malik Shahzad Muzaffar wrote:
sounds good to me
?
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, orunsubscribe.[ABFZX3WCLGNXDYMCNDCWLQDSCZYYDA5CNFSM4LEPES22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZ
GOFCTJTDA.gif]
|
PR description:
Extend biglib to include certain applications which need to be run with some of the existing libraries in biglib
PR validation:
Tested by standard process
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not to be back ported