Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1T EMTF fix for pT assignment bug in UL2016 MC processing (CMSSW_10_6_X) #29156

Merged
merged 2 commits into from Mar 11, 2020

Conversation

abrinke1
Copy link
Contributor

@abrinke1 abrinke1 commented Mar 9, 2020

Back-port of #29080 to CMSSW_10_6_X, fixing only 2016 configuration issues (not 2017).

@srimanob , @rekovic , @davignon , @BenjaminRS , @jiafulow

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2020

A new Pull Request was created by @abrinke1 for CMSSW_10_6_X.

It involves the following packages:

L1Trigger/L1TMuonEndCap

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

srimanob commented Mar 9, 2020

@abrinke1
Thanks. I put this PR for the discussion in the release meeting tomorrow.

@srimanob
Copy link
Contributor

@rekovic @benkrikler @silviodonato
Could you please help to trigger the test? Thanks.

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5096/console Started: 2020/03/10 12:25

@cmsbuild
Copy link
Contributor

+1
Tested at: 4f8ffc4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b31b27/5096/summary.html
CMSSW: CMSSW_10_6_X_2020-03-09-2300
SCRAM_ARCH: slc7_amd64_gcc700

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b31b27/5096/summary.html

Comparison Summary:

  • You potentially added 95 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212324
  • DQMHistoTests: Total failures: 3596
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3208394
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Mar 11, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
This PR will be included in a special CMSSW_10_6_11_CANDIDATE release, as requested by PPD.
I will open a PR to revert this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants