New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing HLTSeedL1LogicScalers #29171
removing HLTSeedL1LogicScalers #29171
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29171/14140
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29171/14141
|
A new Pull Request was created by @Sam-Harper (Sam Harper) for master. It involves the following packages: DQM/Integration @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The DQM group alerted us to the fact this module no longer works in CMSSW_11_1_0_pre3. On closer inspection, it was found to be hardcoded to the legacy L1 not run since 2016 and thus did nothing. Further inspection also implies that it hasnt been used since sometime around Run1 due to the paths it was monitoring. Given we've survived without it so far, I propose rather than fix it, we delete it.
Using the lxr, I deleted all references to it, even those that were commented out.
PR validation:
It currently doesnt run so is unlikely to be in any validation workflow.