Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Run3 GEM to use the eMap from the DB #29194

Merged
merged 2 commits into from Mar 23, 2020

Conversation

watson-ij
Copy link
Contributor

@watson-ij watson-ij commented Mar 12, 2020

PR description:

Fix for GEM crashing in Run3 data due to the emap not being read from the database. This patch instructs run3 to also use dbEmaps, as was done in slice test (its a minimal change as currently only slice test and run 3 emaps are in the db).

PR validation:

I tested on one of the files [1] and it no longer crashes. There are still warnings of the form

%MSG-e BadDigiInput: GEMRecHitProducer:gemRecHits 11-Mar-2020 11:39:34
CET Run: 335670 Event: 4434
Failed to find GEMEtaPartition for ID Re -1 Ri 1 St 1 La 2 Ch 25 Ro 8
%MSG

which is due to currently only the slice test geometry being in the DB, which is being worked on.

I haven't checked on MC though.

[1] cmsDriver.py GEM --step=RAW2DIGI,L1Reco,RECO --filein=/store/data/Commissioning2020/MinimumBias/RAW/v1/000/335/670/00000/5F3ECF4A-0637-844F-AE67-6BB424F0BF80.root --data --conditions 110X_dataRun3_Prompt_v3 --no_exec --era Run3

@jshlee @hyunyong

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29194/14168

  • This PR adds an extra 12KB to repository

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 12, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5155/console Started: 2020/03/12 12:20

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @watson-ij (Ian J. Watson) for master.

It involves the following packages:

EventFilter/GEMRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jshlee, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 0400cce
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9ce50/5155/summary.html
CMSSW: CMSSW_11_1_X_2020-03-11-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9ce50/5155/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 343 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680593
  • DQMHistoTests: Total failures: 620
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2679654
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 12, 2020

Reco comparison results: 343 differences found in the comparisons

it looks like run3 and phase2 MC is broken for GEMs using the database for emap.
Do we have a good payload to replace at least the Run3 version for the MC global tag (IIUC it's 111X_mcRun3_2021_realistic_v1 now).
For phase2 I can imagine that we still need a "hardcoded" emap.

@watson-ij
Copy link
Contributor Author

We have a candidate GT for GEM eMap in MC. If I run the ttbar 2021 workflow with the auto GT and then with the following:
111X_mcRun3_2021_realistic_Candidate_2020_03_13_03_56_33
I see that the auto GT doesn't have GEM rechits (as seen in the comparison plots), but they're there for the candidate GT.

@slava77
Copy link
Contributor

slava77 commented Mar 13, 2020

assign alca

I'm adding alca to keep track of the GT update.
I prefer that we have the GEM emap at least for the Run3 workflows.

@watson-ij
is it practical to also make a GT payload for emap for phase2?
If not, please add phase2_GEM modifier and apply it in
https://github.com/cms-sw/cmssw/blob/master/Configuration/Eras/python/Era_Phase2_cff.py
while removing in copyAndExclude the run3_GEM currently inherited from Run3.

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@christopheralanwest,@franzoni,@tlampen,@pohsun,@tocheng you have been requested to review this Pull request/Issue and eventually sign? Thanks

@perrotta
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) #29210
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 0fd5cc6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d2e15/5242/summary.html
CMSSW: CMSSW_11_1_X_2020-03-17-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d2e15/5242/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d2e15/159.0_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RECOHI2021PPRECO+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d2e15/159.1_QCD_Pt_80_120_14_HI_2021+QCD_Pt_80_120_14_HI_2021+DIGIHI2021PPRECO+RECOHI2021PPRECO+HARVESTHI2021PPRECO
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d2e15/159.2_PhotonJets_Pt_10_14_HI_2021+PhotonJets_Pt_10_14_HI_2021+DIGIHI2021PPRECO+RECOHI2021PPRECO+HARVESTHI2021PPRECO
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-0d2e15/159.3_ZMM_14_HI_2021+ZMM_14_HI_2021+DIGIHI2021PPRECO+RECOHI2021PPRECO+HARVESTHI2021PPRECO

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692437
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692104
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 21, 2020

+1

for #29194 0fd5cc6

@slava77
Copy link
Contributor

slava77 commented Mar 21, 2020

@silviodonato
this PR is to be merged with #29210

@slava77
Copy link
Contributor

slava77 commented Mar 21, 2020

unassign alca
the feature needed for this PR is in a separate PR #29210 , no need to have the extra signature here

@christopheralanwest
Copy link
Contributor

@silviodonato
Copy link
Contributor

@christopheralanwest the difference is related to #29237

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

waiting for #29210

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 97d4788 into cms-sw:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants