Fixed bug in the unit tests #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug was introduced into these unit tests where a reference to a stack variable was added to a lambda but that lambda was not used from within the scope of the declaring function. This problem was only seen when the tests were compiled non-optimized.
|
The following categories have been signed by chrjones (a.k.a. @Dr15Jones on GitHub): Core @cms-git-visualization, @cms-git-core, @cms-git-geometry |
ghost
assigned 
|
Given all the tests were passing also before, I just made sure that was still the case. |
makortel
pushed a commit
to makortel/cmssw
that referenced
this pull request
Apr 22, 2015
An helper script to copy indexes around.
Fedespring
pushed a commit
to Fedespring/cmssw
that referenced
this pull request
Feb 12, 2019
Don't leave nCuts in VIDNestedWPBitmapProducer uninitialized
makortel
added a commit
to makortel/cmssw
that referenced
this pull request
Mar 22, 2019
Do not create event if the CUDA stream is idle, i.e. has already finished all work that was queued, at the point when data products are wrapped/emplaced for/to edm::Event. When creating an event, create only a single event per producer, i.e. all products of a producer share the same event. Include a unit test checking the assumed behaviour of CUDA events and streams.
bi-ran
pushed a commit
to bi-ran/cmssw
that referenced
this pull request
Jun 16, 2020
* add the HF filters * remove the comments in EDProducer * specifying the type (vector of integers) Co-authored-by: ddesouza <dener.lemos@cern.ch>
slava77
pushed a commit
to slava77/cmssw
that referenced
this pull request
Oct 9, 2021
Update README for CMSSW_11_2_0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug was introduced into these unit tests where a reference to a stack
variable was added to a lambda but that lambda was not used from within
the scope of the declaring function. This problem was only seen when
the tests were compiled non-optimized.