Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable temporarily workflow 310, 311, 312 #29218

Merged
merged 1 commit into from Mar 17, 2020
Merged

Disable temporarily workflow 310, 311, 312 #29218

merged 1 commit into from Mar 17, 2020

Conversation

silviodonato
Copy link
Contributor

See issue #29216 .
The wf 310, 311, 312 were added with #29032. They use as pileup dataset /RelValHydjetQ_B12_5020GeV_2021/CMSSW_10_6_0-106X_upgrade2018_realistic_v4-v1/GEN-SIM, but this dataset does not exist. This causes errors in the integration build tests.
A specific pileup dataset will be generated after CMSSW_11_1_0_pre5 using wf 159.
This PR disables the wf 310, 311, 312 because they are crashing. They will be restored as soon as the new pileup dataset /RelValHydjetQ_B12_5020GeV_2021/CMSSW_11_1_0_pre5-111X_upgrade2018_realistic_vX-vY/GEN-SIM will be ready (after CMSSW_11_1_0_pre5)

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone Mar 17, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@silviodonato silviodonato mentioned this pull request Mar 17, 2020
Closed
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29218/14230

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@chayanit, @cmsbuild, @pgunnell, @kpedro88, @zhenhu can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5223/console Started: 2020/03/17 14:31

@cmsbuild
Copy link
Contributor

-1

Tested at: 4810d45

CMSSW: CMSSW_11_1_X_2020-03-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3685/5223/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3685/5223/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3685/5223/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test testGroupSelection had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3685/5223/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3685/5223/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3685/5223/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680593
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680270
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor Author

abort

@silviodonato
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5228/console Started: 2020/03/17 19:53

@cmsbuild
Copy link
Contributor

+1
Tested at: 4810d45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3685/5228/summary.html
CMSSW: CMSSW_11_1_X_2020-03-17-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 1dc2377 into cms-sw:master Mar 17, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c3685/5228/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2680593
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2680272
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@chayanit
Copy link

chayanit commented Apr 9, 2020 •
edited

Hi @mandrenguyen , @silviodonato just to let you know that I have produced GENSIM RelVals for PU mixing in 11_1_0_pre5 and other noPU RelVals. Please feel free to update this PR. https://dmytro.web.cern.ch/dmytro/cmsprodmon/workflows.php?campaign=CMSSW_11_1_0_pre5__HIN_noPU2021-1586349132

BTW, Matthew what is the plan for HIN validation for Run3? Should we start in next pre release?

@silviodonato
Copy link
Contributor Author

btw. the deadline for the next pre-release in Tuesday April 14
https://twiki.cern.ch/twiki/bin/view/CMS/CMSSW_11_1_0

@mandrenguyen mandrenguyen mentioned this pull request Apr 9, 2020
Merged
@mandrenguyen
Copy link
Contributor

These workflows are now reeabled in #29437.
@chayanit We should discuss the validation strategy with @BetterWang who is the validation contact for the HIN PAG.
I would consider that CMSSW_11_1_0 constitutes a new baseline for the future validation of any future Run 3 PbPb developments. As far as validating this release itself, perhaps one could compare to the 2018 heavy-ion workflows, and check whether any differences are expected based on the known differences between the Run 2 and Run 3 detector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available orp-approved pdmv-pending pending-signatures tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silviodonato @cmsbuild @chayanit @mandrenguyen