Added dictionary classes in EcalCondDB to be used in pyroot for the laser monitoring analysis #29240

organtin · 2020-03-19T11:00:52Z

PR description:

-- dictionary classes added to access laser runs from the DB
-- test script added
-- minor (maquillage) corrections to interface IODConfig.h

This pull request updates the previous one where the dictionary classes were missing

PR validation:

usual tests done according to https://cms-sw.github.io/PRWorkflow.html

…classes and script IODConfig.h updated to get rid of Oracle specific message parsing: using a more general method

cmsbuild · 2020-03-19T11:01:16Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-19T11:05:59Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14271

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File OnlineDB/EcalCondDB/interface/IODConfig.h modified in PR(s): Added features to list laser runs extracted from DB. Added dictionary classes for laser DB handling #29196

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14271/code-checks.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14271/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14271/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14271/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-03-19T11:09:07Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-19T11:13:22Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14272

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File OnlineDB/EcalCondDB/interface/IODConfig.h modified in PR(s): Added features to list laser runs extracted from DB. Added dictionary classes for laser DB handling #29196

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14272/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14272/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

… sure I committed the corrected file)

…gantin/cmssw into GOFC-dictionary-classes-added

cmsbuild · 2020-03-19T11:35:27Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-19T11:40:36Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14273

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File OnlineDB/EcalCondDB/interface/IODConfig.h modified in PR(s): Added features to list laser runs extracted from DB. Added dictionary classes for laser DB handling #29196

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14273/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29240/14273/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2020-04-07T17:18:27Z

Pull request #29240 was updated. @ggovi, @cmsbuild can you please check and sign again.

silviodonato · 2020-04-10T09:41:04Z

do you have any comments @ggovi?

ggovi · 2020-04-15T14:40:44Z

Concerning: "Added dictionary classes for laser DB handling", I'm not sure for what you need the dictionary. The condition DB don't use the dictionary.
Concerning the move of classes to CondFormats, if the candidate is EcalCondDBInterface.h I have some doubt, since it looks to me more a service for db data-handling ( read/write ) than a Container defining the data layout. But maybe I'm missing something?

organtin · 2020-04-15T14:53:49Z

I forward the answer to Fabrice Couderc, who in fact is the author of the changes. He asked me to make the modifications since I was in charge of the ECAL DB maintenance.

…

On Wed, 15 Apr 2020 at 16:41, ggovi ***@***.***> wrote: - Concerning: "Added dictionary classes for laser DB handling", I'm not sure for what you need the dictionary. The condition DB don't use the dictionary. - Concerning the move of classes to CondFormats, if the candidate is EcalCondDBInterface.h I have some doubt, since it looks to me more a service for db data-handling ( read/write ) than a Container defining the data layout. But maybe I'm missing something? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#29240 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDYKCDD6E2SHMXFDEGN6FDRMXBP3ANCNFSM4LPGEETQ> .

-- Giovanni Organtini Dip. di Fisica Sapienza Universita' di Roma & INFN-Sez. di Roma P.le A. Moro 2 - 00185 Roma (Tel. +39.06.4991.4329 Fax: +39.06.4453.829)

fcouderc · 2020-04-16T08:00:59Z

@ggovi and thanks @organtin for forwarding me the issue.

we need to use these classes in a python code for the laser monitoring (which is a standalone code, no usage of cmsRun).

Thanks !
Fabrice

ggovi · 2020-04-16T08:25:04Z

@fcouderc ok so you need the dictionary for pyroot?

fcouderc · 2020-04-16T08:34:23Z

@ggovi, yes indeed that's the way I use it.

ggovi · 2020-04-16T08:36:48Z

+1

cmsbuild · 2020-04-16T08:37:11Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5715/console Started: 2020/04/16 10:47

cmsbuild · 2020-04-16T08:37:12Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-04-16T09:01:55Z

@organtin please make the title of the PR more understandable and quote EcalCondDB in it.

cmsbuild · 2020-04-16T10:00:40Z

+1
Tested at: 97ee8d4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-653243/5715/summary.html
CMSSW: CMSSW_11_1_X_2020-04-15-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-16T10:00:43Z

Comparison job queued.

cmsbuild · 2020-04-16T11:32:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-653243/5715/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2696435
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2696114
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

silviodonato · 2020-04-16T11:48:40Z

+1

organtin added 3 commits March 2, 2020 07:36

Added features to list laser runs extracted from DB. Added dicionary …

332b70e

…classes and script IODConfig.h updated to get rid of Oracle specific message parsing: using a more general method

New dictionary classes added

1b06366

Added test script for dictionary classes to read data from the laser DB

1bba218

cmsbuild added this to the CMSSW_11_1_X milestone Mar 19, 2020

cmsbuild added code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Mar 19, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 19, 2020

Merge branch 'master' into GOFC-dictionary-classes-added

09cce71

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 19, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 19, 2020

organtin added 3 commits March 19, 2020 12:26

patch applied (still I need to understand why I need that, since I am…

a043455

… sure I committed the corrected file)

Merge branch 'GOFC-dictionary-classes-added' of https://github.com/or…

d1787d1

…gantin/cmssw into GOFC-dictionary-classes-added

Updated again IODConfig.h to comply with code rules (uff...)

5110e56

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 19, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 19, 2020

cmsbuild added the code-checks-approved label Apr 7, 2020

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Apr 16, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 16, 2020

organtin changed the title ~~Gofc dictionary classes added~~ Added dictionary classes in EcalCondDB to be used in pyroot for the laser monitoring analysis Apr 16, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 16, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 16, 2020

cmsbuild added orp-approved and removed orp-pending labels Apr 16, 2020

cmsbuild merged commit 1056806 into cms-sw:master Apr 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added dictionary classes in EcalCondDB to be used in pyroot for the laser monitoring analysis #29240

Added dictionary classes in EcalCondDB to be used in pyroot for the laser monitoring analysis #29240

organtin commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Apr 7, 2020

silviodonato commented Apr 10, 2020

ggovi commented Apr 15, 2020

organtin commented Apr 15, 2020 via email

fcouderc commented Apr 16, 2020

ggovi commented Apr 16, 2020

fcouderc commented Apr 16, 2020

ggovi commented Apr 16, 2020

cmsbuild commented Apr 16, 2020 •

edited

cmsbuild commented Apr 16, 2020

silviodonato commented Apr 16, 2020

cmsbuild commented Apr 16, 2020

cmsbuild commented Apr 16, 2020

cmsbuild commented Apr 16, 2020

silviodonato commented Apr 16, 2020

Added dictionary classes in EcalCondDB to be used in pyroot for the laser monitoring analysis #29240

Added dictionary classes in EcalCondDB to be used in pyroot for the laser monitoring analysis #29240

Conversation

organtin commented Mar 19, 2020

PR description:

PR validation:

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Mar 19, 2020

cmsbuild commented Apr 7, 2020

silviodonato commented Apr 10, 2020

ggovi commented Apr 15, 2020

organtin commented Apr 15, 2020 via email

fcouderc commented Apr 16, 2020

ggovi commented Apr 16, 2020

fcouderc commented Apr 16, 2020

ggovi commented Apr 16, 2020

cmsbuild commented Apr 16, 2020 • edited

cmsbuild commented Apr 16, 2020

silviodonato commented Apr 16, 2020

cmsbuild commented Apr 16, 2020

cmsbuild commented Apr 16, 2020

cmsbuild commented Apr 16, 2020

silviodonato commented Apr 16, 2020

cmsbuild commented Apr 16, 2020 •

edited