Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ONNXruntime python test #29246

Merged
merged 2 commits into from Mar 24, 2020
Merged

Add ONNXruntime python test #29246

merged 2 commits into from Mar 24, 2020

Conversation

mrodozov
Copy link
Contributor

PR description:

Add a test for onnxruntime python interface we added here:
cms-sw/cmsdist#5668
Taken from this examples:
https://github.com/microsoft/onnxruntime/tree/master/docs/python/examples
uses example model from onnxruntime datasets folder

PR validation:

The test runs

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@mrodozov
Copy link
Contributor Author

please test with cms-sw/cmsdist#5668

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29246/14285

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5668
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5281/console Started: 2020/03/19 23:15

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

PhysicsTools/ONNXRuntime

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1
Tested at: 12ce52a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e67ad8/5281/summary.html
CMSSW: CMSSW_11_1_X_2020-03-19-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e67ad8/5281/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692493
  • DQMHistoTests: Total failures: 24
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692150
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

hold
we need to fix onnxruntime python for aarch64

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Mar 20, 2020
@cmsbuild
Copy link
Contributor

Pull request #29246 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5675
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5291/console Started: 2020/03/20 15:00

@cmsbuild
Copy link
Contributor

+1
Tested at: ee1d704
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-613354/5291/summary.html
CMSSW: CMSSW_11_1_X_2020-03-19-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-613354/5291/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692493
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2692139
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 23, 2020

hold
we need to fix onnxruntime python for aarch64

@smuzaffar is this hold still active ?

@smuzaffar
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Mar 23, 2020
@slava77
Copy link
Contributor

slava77 commented Mar 23, 2020

+1

for #29246 ee1d704

  • looks as described
  • the set up seems somewhat questionable to me, because we are adding a unit test that's supposed to be testing an external itself rather than anything in CMSSW. Shouldn't this be a part of a test of the external?

@smuzaffar
Copy link
Contributor

the set up seems somewhat questionable to me, because we are adding a unit test that's supposed to be testing an external itself rather than anything in CMSSW. Shouldn't this be a part of a test of the external?

@slava77 , you are right but having unit test in cmssw also makes sure that environment of the tool is properly setup within cmssw.

@silviodonato
Copy link
Contributor

merge
@santocch this PR is adding a unit test

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants