Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface for high multiplicity triggers in CSC #29247

Merged
merged 2 commits into from Apr 14, 2020
Merged

Interface for high multiplicity triggers in CSC #29247

merged 2 commits into from Apr 14, 2020

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Mar 20, 2020

PR description:

This PR add a basic interface for high multiplicity triggers (e.g. boosed tau->3 mu, long-lived particles to muon showers, muon-jets, etc.) in CSCs for Run-3 and beyond. At least 2 bits in the ALCT->(O)TMB data stream and at least 1 bit in the (O)TMB->EMTF data stream can be repurposed for such exotic objects. We will reassign the unused synchronization error (syncErr) data word in the LCT. No changes are expected. The bit values have yet to be finalized and implemented.

PR validation:

Tested with WF 20434.0.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29247/14286

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCTriggerPrimitives

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@dildick
Copy link
Contributor Author

dildick commented Mar 20, 2020

In a future PR, I'll probably introduce masks and shifts in the CSCALCTDigi data format. That way I can reserve the two highest bits BXN[4] and BXN[3] to count stubs/hits.

@dildick
Copy link
Contributor Author

dildick commented Mar 23, 2020

Hi, can someone initiate the tests?

@dildick
Copy link
Contributor Author

dildick commented Apr 1, 2020

@fabiocos Can you initiate the tests please?

@silviodonato
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5490/console Started: 2020/04/01 20:12

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

+1
Tested at: 0e6e251
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61aa1d/5490/summary.html
CMSSW: CMSSW_11_1_X_2020-04-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-61aa1d/5490/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691781
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

kind reminder for @rekovic

@rekovic
Copy link
Contributor

rekovic commented Apr 14, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8fe789c into cms-sw:master Apr 14, 2020
@dildick dildick deleted the from-CMSSW_11_1_X_2020-03-19-1100-Interface-high-multiplicity-triggers branch April 15, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants