Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed boost::unordered_map for std::unordered_map #29292

Merged
merged 1 commit into from Mar 26, 2020

Conversation

camolezi
Copy link
Contributor

PR description:

Changed boost::unordered_map for std::unordered_map. In this case they should be interchangeable.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

@vgvassilev
@davidlange6

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29292/14351

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @camolezi (Lucas Camolezi) for master.

It involves the following packages:

Fireworks/Core

@makortel, @cmsbuild, @Dr15Jones, @alja can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@camolezi camolezi marked this pull request as ready for review March 24, 2020 21:31
@makortel
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5362/console Started: 2020/03/24 23:13

@cmsbuild
Copy link
Contributor

+1
Tested at: 7ff9c93
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d5e9/5362/summary.html
CMSSW: CMSSW_11_1_X_2020-03-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d5e9/5362/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d5e9/5362/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-00d5e9/5362/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1761 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2690122
  • DQMHistoTests: Total failures: 2132
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2687671
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -575.173 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -3.633 KiB Physics/B2G
  • DQMHistoSizes: changed ( 1000.0,... ): 0.027 KiB Physics/Exotica
  • DQMHistoSizes: changed ( 20034.0,... ): -88.393 KiB MTD/ETL
  • DQMHistoSizes: changed ( 20034.0,... ): -45.637 KiB MTD/BTL
  • DQMHistoSizes: changed ( 20034.0,... ): 12.768 KiB MTD/GlobalReco
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@alja
Copy link
Contributor

alja commented Mar 25, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @silviodonato, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 691f0b7 into cms-sw:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants