Apply puppi weight in BoostedDoubleSV btaginfo for packedPFCandidates #29300

ahinzmann · 2020-03-25T13:27:38Z

PR description:

Resolve issue #29132.
This makes the treatment of puppi weights consistent between BoostedDoubleSV btaginfo computed from particleFlow and packedPFcandidates.
It introduces small changes in the b-tag discriminators computed from PackedCandidates, namely pfDeepDoublevJetTags and pfMassIndependentDeepDoublevJetTags.

PR validation:

runTheMatrix -l 136.8311
Verified that the corresponding discriminator value change.
@emilbols @hqucms @XavierAtCERN

if this PR is a backport please specify the original PR and why you need to backport that PR:

no backport planned.

…d and PF candidates

cmsbuild · 2020-03-25T13:28:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-03-25T13:33:06Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29300/14365

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/PatAlgos/python/tools/jetTools.py modified in PR(s): PUPPI MET in RECO #29254, Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172

cmsbuild · 2020-03-25T13:33:33Z

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/SecondaryVertex

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@jdamgov, @emilbols, @gouskos, @jdolen, @smoortga, @riga, @schoef, @rappoccio, @mariadalfonso, @JyothsnaKomaragiri, @nhanvtran, @gpetruc, @gkasieczka, @clelange, @hatakeyamak, @ferencek, @mverzett, @andrzejnovak, @peruzzim, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@davidlange6, @silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-03-25T13:48:05Z

@cmsbuild please test workflow 25202.01

cmsbuild · 2020-03-25T13:48:27Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 25202.01
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5376/console Started: 2020/03/25 14:52

cmsbuild · 2020-03-25T15:20:24Z

-1

Tested at: 2d2f563

CMSSW: CMSSW_11_1_X_2020-03-25-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-475d3e/5376/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following workflows:
25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

25202.01 step5

runTheMatrix-results/25202.01_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15MC_PU25_JME.log

cmsbuild · 2020-03-25T15:20:27Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

perrotta · 2020-03-25T15:26:29Z

@cmsbuild please test with #29296 workflow 25202.01

ahinzmann · 2020-03-28T10:44:03Z

Let's test this one again?

perrotta · 2020-03-28T12:15:39Z

please test workflow 25202.01

cmsbuild · 2020-03-28T12:16:02Z

The tests are being triggered in jenkins.
Test Parameters:

MATRIX_EXTRAS = 25202.01
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5417/console Started: 2020/03/28 13:22

cmsbuild · 2020-04-08T07:14:09Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-04-08T07:18:39Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29300/14571

This PR adds an extra 32KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/PatAlgos/python/tools/jetTools.py modified in PR(s): PUPPI MET in RECO #29254, Restore TF and MXNet-based inference for DeepJet, DeepDoubleX and DeepAK8 #29172

cmsbuild · 2020-04-08T07:19:05Z

Pull request #29300 was updated. @perrotta, @cmsbuild, @santocch, @slava77 can you please check and sign again.

slava77 · 2020-04-08T12:29:25Z

@cmsbuild please test

cmsbuild · 2020-04-08T12:29:46Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5590/console Started: 2020/04/08 14:34

cmsbuild · 2020-04-08T13:55:21Z

+1
Tested at: 40ecd33
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-475d3e/5590/summary.html
CMSSW: CMSSW_11_1_X_2020-04-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-04-08T13:55:23Z

Comparison job queued.

cmsbuild · 2020-04-08T15:21:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-475d3e/5590/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 154 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2692110
DQMHistoTests: Total failures: 61
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2691730
DQMHistoTests: Total skipped: 319
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 147 log files, 16 edm output root files, 34 DQM output files

slava77 · 2020-04-08T15:48:49Z

+1

for #29300 40ecd33

code changes are in line with the PR description and the follow up review
jenkins tests pass and comparisons with the baseline show differences only in available slimmedJetsAK8 pairDiscriVector variables with somewhat insignificant changes in the distributions

silviodonato · 2020-04-10T09:38:40Z

do you have any comments @santocch ?

santocch · 2020-04-13T09:18:50Z

+1

cmsbuild · 2020-04-13T09:19:15Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-04-13T18:14:26Z

+1

Apply puppi weight consistently in BoostedDoubleSV btaginfo for packe…

2d2f563

…d and PF candidates

cmsbuild added this to the CMSSW_11_1_X milestone Mar 25, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 25, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 25, 2020

cmsbuild added tests-started and removed tests-pending labels Mar 25, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Mar 25, 2020

cmsbuild mentioned this pull request Mar 25, 2020

PUPPI MET in RECO #29254

Merged

cmsbuild removed the comparison-notrun label Mar 28, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 8, 2020

cmsbuild added tests-started and removed tests-pending labels Apr 8, 2020

cmsbuild added tests-approved and removed tests-started labels Apr 8, 2020

cmsbuild added comparison-available and removed comparison-pending labels Apr 8, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Apr 8, 2020

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Apr 13, 2020

cmsbuild added orp-approved and removed orp-pending labels Apr 13, 2020

cmsbuild merged commit bbcddfd into cms-sw:master Apr 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apply puppi weight in BoostedDoubleSV btaginfo for packedPFCandidates #29300

Apply puppi weight in BoostedDoubleSV btaginfo for packedPFCandidates #29300

ahinzmann commented Mar 25, 2020

cmsbuild commented Mar 25, 2020

cmsbuild commented Mar 25, 2020

cmsbuild commented Mar 25, 2020

perrotta commented Mar 25, 2020

cmsbuild commented Mar 25, 2020 •

edited

cmsbuild commented Mar 25, 2020

cmsbuild commented Mar 25, 2020

perrotta commented Mar 25, 2020

ahinzmann commented Mar 28, 2020

perrotta commented Mar 28, 2020

cmsbuild commented Mar 28, 2020 •

edited

cmsbuild commented Apr 8, 2020

cmsbuild commented Apr 8, 2020

cmsbuild commented Apr 8, 2020

slava77 commented Apr 8, 2020

cmsbuild commented Apr 8, 2020 •

edited

cmsbuild commented Apr 8, 2020

cmsbuild commented Apr 8, 2020

cmsbuild commented Apr 8, 2020

slava77 commented Apr 8, 2020

silviodonato commented Apr 10, 2020

santocch commented Apr 13, 2020

cmsbuild commented Apr 13, 2020

silviodonato commented Apr 13, 2020

Apply puppi weight in BoostedDoubleSV btaginfo for packedPFCandidates #29300

Apply puppi weight in BoostedDoubleSV btaginfo for packedPFCandidates #29300

Conversation

ahinzmann commented Mar 25, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Mar 25, 2020

cmsbuild commented Mar 25, 2020

cmsbuild commented Mar 25, 2020

perrotta commented Mar 25, 2020

cmsbuild commented Mar 25, 2020 • edited

cmsbuild commented Mar 25, 2020

cmsbuild commented Mar 25, 2020

perrotta commented Mar 25, 2020

ahinzmann commented Mar 28, 2020

perrotta commented Mar 28, 2020

cmsbuild commented Mar 28, 2020 • edited

cmsbuild commented Apr 8, 2020

cmsbuild commented Apr 8, 2020

cmsbuild commented Apr 8, 2020

slava77 commented Apr 8, 2020

cmsbuild commented Apr 8, 2020 • edited

cmsbuild commented Apr 8, 2020

cmsbuild commented Apr 8, 2020

cmsbuild commented Apr 8, 2020

slava77 commented Apr 8, 2020

silviodonato commented Apr 10, 2020

santocch commented Apr 13, 2020

cmsbuild commented Apr 13, 2020

silviodonato commented Apr 13, 2020

cmsbuild commented Mar 25, 2020 •

edited

cmsbuild commented Mar 28, 2020 •

edited

cmsbuild commented Apr 8, 2020 •

edited