Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Flow generator truth information #29361

Merged
merged 5 commits into from Apr 2, 2020

Conversation

jpata
Copy link
Contributor

@jpata jpata commented Mar 31, 2020

PR description:

Enable the production of particle-level generator truth information for PFCandidates.

  • update CaloTruthProducer to optionally allow association of generator particles with the current ECAL and HCAL geometry for PF generator-level studies
  • add a PF-specific EDAnalyzer for dumping PFCandidates and the associated GenParticles from TrackingTruth and CaloTruth.

Slides from the PF meeting with the rationale and early results:

We do not change the standard reconstruction sequences.

PR validation:

runTheMatrix is in progress.

If this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport.

Before submitting your pull requests, make sure you followed this checklist:

WIP - comments welcome.

cc @hatakeyamak @bendavid @lgray

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29361/14454

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpata (Joosep Pata) for master.

It involves the following packages:

SimGeneral/CaloAnalysis
SimGeneral/MixingModule
Validation/RecoParticleFlow

@andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@makortel, @fabiocos, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

@jpata can you please add yourself with your git username to the PF Validation e-group for future refrences?
https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts#Particle_Flow_PF

@civanch
Copy link
Contributor

civanch commented Mar 31, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5473/console Started: 2020/04/01 01:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

+1
Tested at: 0074688
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9dc7c/5473/summary.html
CMSSW: CMSSW_11_1_X_2020-03-31-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9dc7c/5473/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691788
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Apr 1, 2020

+1

@civanch
Copy link
Contributor

civanch commented Apr 2, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2b40e57 into cms-sw:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants