vavilov parameters kappa fix

[OzAmram]

A small PR to fix the issue reported here. The issue was caused by rounding differences between float and doubles. Namely that the value of kappa when on the edge of its allowed range as a float (0.01f) was less than the double value (0.01) used to check for errors. This fix simply adds a small amount to Kappa if it is exactly on the edge.

Tested by following the procedure outlined here and checking that this does indeed fix the error.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29399/14542

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29399/14542/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29399/14542/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[slava77]

Code check has found code style and quality issues which could be resolved by applying following patch(s)

this should be addressed before full PR tests can start

[cmsbuild]

The code-checks are being triggered in jenkins.

[OzAmram]

Oops sorry I forgot to run the code format before pushing. Should be ok now

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29399/14545

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @OzAmram (Oz Amram) for master.

It involves the following packages:

CondFormats/SiPixelTransient

@ggovi, @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@mmusich, @seemasharmafnal, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test workflow 13034.0

[cmsbuild]

The tests are being triggered in jenkins.
Test Parameters:

• MATRIX_EXTRAS = 13034.0
  https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5560/console Started: 2020/04/07 03:18

[cmsbuild]

+1
Tested at: 933ab69
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb9bcc/5560/summary.html
CMSSW: CMSSW_11_1_X_2020-04-06-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[OzAmram]

Ok I just pushed a new commit

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29399/14661

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #29399 was updated. @ggovi, @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5686/console Started: 2020/04/14 10:11

[perrotta]

Still not clear to me why you do not apply the boundary limitation at L4067 to the returned double kappa, instead than to the intermediate float kappavav_. Applying it to the returned double value would avoid the remote possibility of non continuos returned value in the (indeed negligibly tiny) interval between 0.01f and 0.01f + 0.0000001f .

This is indoubtly a ultra-minor point: once tests succeed this PR will be considered ready to be merged by reco.

[cmsbuild]

+1
Tested at: 12b959f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb9bcc/5686/summary.html
CMSSW: CMSSW_11_1_X_2020-04-13-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb9bcc/5686/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2695166
• DQMHistoTests: Total failures: 22
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2694825
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[perrotta]

+1

• It fixes the rare issue posted in Error in IB test wf 13034.0 #29251 by bounding the values of the kappa vavilov parameter to their physically allowed values (they could have been exceeded by rounding approximations in the float to double conversion)
• Jenkins tests pass and show no differences in reco outputs

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1