New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD Geometry: DD4hep migration, preliminary update and cleaning of ideal geometry test #29407
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29407/14558
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: DataFormats/ForwardDetId @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
+1 @fabiocos , since some moment, we are trying use LogVerbatim instead of LogInfo, because in the last variant log files are polluted by date and time at each printout, which make a problem to use diff/tkdiff |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
@civanch in general I agree about |
please test workflow 23434.1001 |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready There are some workflows for which there are errors in the baseline: @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
@silviodonato the problems in the IB need to be solved, before a meaningful test for this PR can be made |
+1
|
PR description:
This PR updates DD4hep scenarios D50 and D53 according to the most recent updates, and refresh the
MTDCommonData
tests. With the opportunity a few constants for the scenario D53 are added toETLDetId
andETLNumberingScheme
, and the MtdSD test verbosity is improved. While preparing the migration ofMTDNumberingBuilder
(to come in a next PR), I realized that even the old basic DD4hep geometry test had occasional problems with the printed strings, but no sign of issue with the computed DetIds or positions (which makes me think this is mostly a printout issue, although I do not fully understand it).I have refreshed and simplified the test to avoid useless code duplication and multiple output streams, getting the same results.
PR validation:
The standalone
MTDCommonData
tests run and produce consistent output.