Run3-sim65 Try to fix 0 TrackID for saved tracks

[bsunanda]

PR description:

Try to fix 0 TrackID for saved hits in the calorimeter. Also add namespace and clean up some of the debug statements

PR validation:

Tested with standard runTheMatrix.py and also cfg's in SimG4CMS/Calo/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29409/14562

• This PR adds an extra 28KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29409/14562/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29409/14562/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29409/14564

• This PR adds an extra 28KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5580/console Started: 2020/04/07 23:53

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4CMS/Calo
SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @fabiocos, @rovere this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 29aae6a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d8bff/5580/summary.html
CMSSW: CMSSW_11_1_X_2020-04-07-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d8bff/5580/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 41 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2692110
• DQMHistoTests: Total failures: 37
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2691754
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

@bsunanda , in this PR mainly namespace and LogVerbatim are added. Concerning trackID=0, it is not obvious what is changed for that. I would rename the title and extend description.

[bsunanda]

@civanch I modified the print statements to find out the cause of the track id = 0. In fact the fix is in the code of TrackingAction. It is a subtle change in the statement: bool withAncestor = ((extractor_(aTrack).getIDonCaloSurface() == aTrack->GetTrackID()) ||
(extractor_(aTrack).getIDfineCalo() == aTrack->GetTrackID()) || (extractor_(aTrack).isAncestor()));

[bsunanda]

@civanch Since I had to edit the files for CaloSD and CaloTrackingAction to find out the cause, I made changes by adding namespace to make the code looking more transparent. But my main concern was to get rid of trackId = 0

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1