Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running code-format for alca-db #29420

Merged
merged 1 commit into from Apr 16, 2020
Merged

Running code-format for alca-db #29420

merged 1 commit into from Apr 16, 2020

Conversation

cmsbuild
Copy link
Contributor

@cmsbuild cmsbuild commented Apr 8, 2020

Applying code-format for CMSSW category alca,db.
See the build logs here https://cmssdt.cern.ch/jenkins/job/GitHub-refactor-cmssw-module/482//console

cms-bot has successfully run the following:

  • scram build code-checks-all
  • scram build code-format-all
  • scram build

Due to a bug in buildrules, clang-tidy was not run properly since the update of LLVM 9.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 8, 2020

please test

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29420/14580

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 8, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5594/console Started: 2020/04/08 16:11

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 8, 2020

A new Pull Request was created by @cmsbuild for master.

It involves the following packages:

CondCore/DBOutputService
CondFormats/HcalObjects

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 8, 2020

+1
Tested at: 1a5d7b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b73e26/5594/summary.html
CMSSW: CMSSW_11_1_X_2020-04-07-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 8, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 8, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b73e26/5594/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691761
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@pohsun
Copy link

pohsun commented Apr 12, 2020

+1

@ggovi
Copy link
Contributor

ggovi commented Apr 15, 2020

+1

@cmsbuild
Copy link
Contributor Author

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 622cc9c into master Apr 16, 2020
@smuzaffar smuzaffar deleted the code-format-alca-db-47b991 branch June 13, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants