Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug in UL16 PU profile #29433

Merged
merged 1 commit into from Apr 9, 2020
Merged

fixed bug in UL16 PU profile #29433

merged 1 commit into from Apr 9, 2020

Conversation

gkrintir
Copy link
Contributor

@gkrintir gkrintir commented Apr 8, 2020

PR description:

This fixes the pileup scenario for the 2016 ultra legacy (periods B-H), i.e.,

"2016_25ns_UltraLegacy_PoissonOOTPU"

forward port from cms-sw:CMSSW_10_6_X #29431

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29433/14596

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 8, 2020

A new Pull Request was created by @gkrintir (Georgios Konstantinos Krintiras) for master.

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Apr 9, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5618/console Started: 2020/04/09 09:46

@silviodonato
Copy link
Contributor

urgent

@cmsbuild cmsbuild added the urgent label Apr 9, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

+1
Tested at: f8fefce
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f79b76/5618/summary.html
CMSSW: CMSSW_11_1_X_2020-04-08-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f79b76/5618/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2692110
  • DQMHistoTests: Total failures: 59
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691732
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor

civanch commented Apr 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2e2f2ed into cms-sw:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants