Add possibility to specify GBT Id only to DTC cabling map producer #29443
Conversation
…can choose to provide the elink and gbt ids, provide the gbt id and generate a dummy sequential elink id, or generate both
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29443/14610
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
| else { | ||
| std::ostringstream message; | ||
| message << "Parameter dummy_fill_mode with invalid value: " << dummy_fill_mode_param; | ||
| throw cms::Exception(message.str()); |
There was a problem hiding this comment.
this should be:
throw cms::Exception("InvalidDummyFillMode") << "Parameter dummy_fill_mode with invalid value: " << dummy_fill_mode_param;
the value used in the exception constructor is the category, not the message.
There was a problem hiding this comment.
Fixed, also in other parts of the code, to specify the category properly.
|
@luigicalligaris in addition to the review comment:
|
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29443/14613
|
|
A new Pull Request was created by @luigicalligaris (Luigi Calligaris) for master. It involves the following packages: CondTools/SiPhase2Tracker @christopheralanwest, @kpedro88, @cmsbuild, @tocheng, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
|
When good for you, ready to squash |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29443/14648
|
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+upgrade |
|
alca: @pohsun @tlampen @tocheng @christopheralanwest |
|
any objection from generators side (@alberto-sanchez @agrohsje @efeyazgan @mkirsano @qliphy @SiewYan) ? |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
+1 |
Change the PSet parameters in the DTCCablingMapProducer, so the user can choose to provide the elink and gbt ids, provide the gbt id and generate a dummy sequential elink id, or generate both
PR description:
Following feature request 29390 (#29390) the producer code was changed, such that the user can choose three operating modes:
The parameter choosing the mode is implemented as a string, and the corresponding state flag is implemented as an int type (enum) for performance reasons.
Due to the increased risk of the user choosing the wrong mode or column configuration, and due to the cryptic message resulting from an out-of-bound access to a vector when using operator[], bound checks have been activated replacing operator[] with at()
No other changes to the code were introduced, and the formatting style was kept the same.
No dependence on external PRs.
PR validation:
Validated on the DTC cabling map payload production, retrieve and dump PSets
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport.