Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeepJet scores for gluon and light quark tagging in JME Custom-NanoAODs #29452

Merged

Conversation

nurfikri89
Copy link
Contributor

This PR involves the following changes:

Add DeepJet scores for gluon & light quark tagging in the JME Custom-NanoAODs. Needed for performance comparison studies on different quark-gluon discrimination methods. The variables are not saved in the main NanoAODs by default.

This PR needs to be backported to 10_6_X, once merged, for the ultra legacy campaigns.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@nurfikri89
Copy link
Contributor Author

FYI JMAR convenors @camclean @alefisico

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29452/14631

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @santocch, @fgolf, @peruzzim can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@santocch
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 13, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5672/console Started: 2020/04/13 11:22

@cmsbuild
Copy link
Contributor

+1
Tested at: 0ed2bfb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05fa27/5672/summary.html
CMSSW: CMSSW_11_1_X_2020-04-12-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05fa27/5672/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2695166
  • DQMHistoTests: Total failures: 52
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694795
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

do you have any comments @santocch @fgolf @peruzzim ?

@santocch
Copy link

+1

@silviodonato
Copy link
Contributor

@peruzzim ?

@peruzzim
Copy link
Contributor

+xpog

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 34de10b into cms-sw:master Apr 20, 2020
@nurfikri89 nurfikri89 deleted the from111X_nanojme_deepjetprobgprobuds branch January 25, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants