New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L1Trigger/TrackerDTC fix for SLHCUpgradeSimulations/Geometry unit test failure (#29474) #29478
Conversation
The code-checks are being triggered in jenkins. |
Hello @tschuh , thanks for the fix, can you make the title more explicit, to make sure we know which fix you are talking about in the release notes where the title will be displayed ?... thanks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29478/14682
|
A new Pull Request was created by @tschuh for master. It involves the following packages: L1Trigger/TrackerDTC @cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
urgent |
solves #29474 |
I ran the unit test manually, merging this PR in the latest IB, and it now succeeds. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
looks like other PRs were merged with this one and caused comparison failures |
Thanks |
merge |
PR description:
CheckHistory was set to True by default by mistake, now corrected.