Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1Trigger/TrackerDTC fix for SLHCUpgradeSimulations/Geometry unit test failure (#29474) #29478

Merged
merged 1 commit into from Apr 15, 2020

Conversation

tschuh
Copy link
Contributor

@tschuh tschuh commented Apr 15, 2020

PR description:

CheckHistory was set to True by default by mistake, now corrected.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@boudoul
Copy link
Contributor

boudoul commented Apr 15, 2020

Hello @tschuh , thanks for the fix, can you make the title more explicit, to make sure we know which fix you are talking about in the release notes where the title will be displayed ?... thanks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29478/14682

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tschuh for master.

It involves the following packages:

L1Trigger/TrackerDTC

@cmsbuild, @rekovic, @benkrikler, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@tschuh tschuh changed the title Quick fix for #29474 L1Trigger/TrackerDTC fix for SLHCUpgradeSimulations/Geometry unit test failure (#29474) Apr 15, 2020
@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 15, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5703/console Started: 2020/04/15 15:23

@silviodonato
Copy link
Contributor

urgent

@silviodonato
Copy link
Contributor

solves #29474

@kpedro88
Copy link
Contributor

I ran the unit test manually, merging this PR in the latest IB, and it now succeeds.

@cmsbuild
Copy link
Contributor

+1
Tested at: 7f0a4e9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11f21b/5703/summary.html
CMSSW: CMSSW_11_1_X_2020-04-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11f21b/5703/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11f21b/5703/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11f21b/5703/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 41412 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 383647
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 2312463
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.011 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.469 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): 0.527 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.047 KiB SiStrip/MechanicalView
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

looks like other PRs were merged with this one and caused comparison failures

@silviodonato
Copy link
Contributor

I ran the unit test manually, merging this PR in the latest IB, and it now succeeds.

Thanks

@silviodonato
Copy link
Contributor

merge
The differences are due to the update of GEANT4

@cmsbuild cmsbuild merged commit d81cdd1 into cms-sw:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants