Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herwig7.2 upgrade 9 3 #29538

Merged
merged 2 commits into from Apr 23, 2020

Conversation

Dominic-Stafford
Copy link
Contributor

PR description:

Update of Herwig 7 interface to allow update of Herwig 7.1.4->7.2.0, and reintroduced cmssw/Configuration/Generator/python/TT_13TeV_Pow_Herwig7_cff.py, which is needed for workflow 535, but seems to have been removed

PR validation:

Has been tested with runTheMatrix workflow 535, and the test commands on the Herwig twiki

If this PR is a backport please specify the original PR and why you need to backport that PR:

First part is a backport of #29523 to allow use of Herwig 7.2 for 2017 production

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dominic-Stafford for CMSSW_9_3_X.

It involves the following packages:

Configuration/Generator
GeneratorInterface/Herwig7Interface

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @alberto-sanchez, @agrohsje, @mkirsano, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5774

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 22, 2020

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5774
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 231353d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-136d9f/5827/summary.html
CMSSW: CMSSW_9_3_X_2020-04-19-0000
SCRAM_ARCH: slc6_amd64_gcc630

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-136d9f/5827/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-136d9f/535.0_TTbar_13TeV_Pow_herwig7+TTbar_13TeV_Pow_herwig7+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 198
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624073
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Apr 23, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1
see #29365 about the DQMHistoTests failures

@cmsbuild cmsbuild merged commit 7bb8a82 into cms-sw:CMSSW_9_3_X Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants