Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for root de-serialization with streamer info #2958

Merged
merged 1 commit into from Mar 24, 2014

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Mar 21, 2014

  • Fix for root de-serialization: deleting streamer info at right time, allowing for non-available streamerinfo
  • Added command for new conddb format validation

Packages affected:
CondCore/CondDB
CondCore/Utilities

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_7_1_X.

Fix for root de-serialization with streamer info

It involves the following packages:

CondCore/CondDB
CondCore/Utilities

@ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@apfeiffer1
Copy link
Contributor

+1

On Fri, Mar 21, 2014 at 4:33 PM, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @ggovi https://github.com/ggovi for
CMSSW_7_1_X.

Fix for root de-serialization with streamer info

It involves the following packages:

CondCore/CondDB
CondCore/Utilities

@ggovi https://github.com/ggovi, @cmsbuild https://github.com/cmsbuild,
@apfeiffer1 https://github.com/apfeiffer1, @deganohttps://github.com/degano,
@nclopezo https://github.com/nclopezo can you please review it and
eventually sign? Thanks.
@ghellwig https://github.com/ghellwig this is something you requested
to watch as well.
You can sign-off by replying to this message having '+1' in the first line
of your reply.
You can reject by replying to this message having '-1' in the first line
of your reply.
@nclopezo https://github.com/nclopezo, @ktf https://github.com/ktfyou are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of
your comment.

Reply to this email directly or view it on GitHubhttps://github.com//pull/2958#issuecomment-38287807
.

Thanks,
cheers, andreas

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Mar 24, 2014
CondCore -- Fix for root de-serialization with streamer info
@nclopezo nclopezo merged commit 3d99b5e into cms-sw:CMSSW_7_1_X Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants