Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Run 3 beam pipe + Minor update of Phase 2 beam pipe #29589

Merged
merged 4 commits into from May 5, 2020

Conversation

ghugo83
Copy link
Contributor

@ghugo83 ghugo83 commented Apr 29, 2020

Also includes minor fix in Phase 2 BP.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29589/14915

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ghugo83 for master.

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 29, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5911/console Started: 2020/04/29 21:01

@cmsbuild
Copy link
Contributor

+1
Tested at: 95424cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c262e9/5911/summary.html
CMSSW: CMSSW_11_1_X_2020-04-29-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c262e9/5911/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12651 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696435
  • DQMHistoTests: Total failures: 158746
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2537370
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@civanch
Copy link
Contributor

civanch commented Apr 30, 2020

Differences are expected in Phase-2 WFs.

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+1
Tested at: 1662d42
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c262e9/6015/summary.html
CMSSW: CMSSW_11_1_X_2020-05-04-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@silviodonato
Copy link
Contributor

Shall we merge this in 11_1_0_pre7?
geometry: @Dr15Jones @civanch @cvuosalo @ianna @makortel @mdhildreth
upgrade: @kpedro88

@boudoul
Copy link
Contributor

boudoul commented May 5, 2020

Hi - Could @ghugo83 add in the title that the Phase2 BP is also modified ? Thanks

@ghugo83 ghugo83 changed the title Add Run 3 Beam pipe Add Run 3 beam pipe + Minor update of Phase 2 beam pipe May 5, 2020
@civanch
Copy link
Contributor

civanch commented May 5, 2020

@silviodonato , yes, we need this asap for Run-3. This PR is an addition of two files, which are not used so far in any testing WF, so it is absolutely safe.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c262e9/6015/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695919
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented May 5, 2020

+upgrade
the new phase 2 beampipe should be included in a new phase 2 "common" subdetector in a future PR

@civanch
Copy link
Contributor

civanch commented May 5, 2020

+1

@cvuosalo already approved this PR

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants