New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gem36 Adding an object MuonGeometryConstants to EventSetup which can give similar functionality as MuonDDDConstants #29590
Conversation
…ar functionality as MuonDDDConstants
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29590/14916
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29590/14917
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/MuonNumbering @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29590/14919
|
The tests are being triggered in jenkins. |
Pull request #29590 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again. |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
-1 Tested at: 7134f71 CMSSW: CMSSW_11_1_X_2020-04-29-1100 I found follow errors while testing this PR Failed tests: HeaderConsistency |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Comparison is ready Comparison Summary:
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Creates an object (MuonGeometryConstants) from DDCompactView of DD4Hep cms::DDCompactView and attaches to EventSetup. This can then be used in all applications (Simulation/Alignment/ ..) without invoking DDDCompactView
PR validation:
Tested with built in cfg files (the implementation is complete for DDD)
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special