Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consumes interface to METProducers #2960

Merged
merged 1 commit into from Mar 29, 2014

Conversation

ptcox
Copy link
Contributor

@ptcox ptcox commented Mar 21, 2014

Since I got pointed at CSCHaloDataProducer I discovered RecoMET/METProducers had several other classes also missing 'consumes', although some classes already had been updated. No idea why only some were done. This branch formally adds the consumes interface where it was missing. But BEWARE! I am no expert on this code, and there is what I consider to be a rather complicated templated class MinMETProducerT that you probably normally wouldn't want me messing with, and now I've given it a vector<EDGetTokenT >. The whole package compiles and builds in 710pre4. But it is in no way tested. I wouldn't have a clue how to do that.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ptcox for CMSSW_7_1_X.

Add consumes interface to METProducers

It involves the following packages:

RecoMET/METProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 28, 2014

checking

@slava77
Copy link
Contributor

slava77 commented Mar 29, 2014

+1

for #2960 462ed06
tested in CMSSW_7_1_X_2014-03-25-1400 (my test area sign329)
no differences as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 29, 2014
Reco -- Add consumes interface to METProducers
@ktf ktf merged commit d0edca0 into cms-sw:CMSSW_7_1_X Mar 29, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants