Delete legacy OutputModule base class

[wddgit]

PR description:

Delete the legacy output module base class and all references to it. Already, nothing was inheriting from it anymore. A few classes were still using its fillDescription function, but I moved them to use the corresponding function from the one::OutputModule and with the changes included here that function should be doing exactly the same thing.

PR validation:

Existing Core unit tests pass. There is no new functionality. Nothing should change. There will just be less code to maintain.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29633/15013

• This PR adds an extra 56KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/WorkerT.cc modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

DQMServices/FwkIO
FWCore/Framework
FWCore/ParameterSet
PhysicsTools/NanoAOD

@smuzaffar, @andrius-k, @Dr15Jones, @makortel, @schneiml, @cmsbuild, @kmaeshima, @jfernan2, @fgolf, @fioriNTU, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@makortel, @gpetruc, @barvic this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5985/console Started: 2020/05/04 21:01

[Dr15Jones]

Interesting discovery about the fillDescriptions calling non-base class versions!

[cmsbuild]

-1

Tested at: 941d584

CMSSW: CMSSW_11_1_X_2020-05-04-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bf254/5985/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test TestFWCoreServicesDriver had ERRORS

[cmsbuild]

Comparison job queued.

[makortel]

Is this the real error in the unit test?

Waiting for stacktrace completion failed: timed out waiting for GDB to complete.

I.e. strack trace generation took too long in the zombie killer test?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bf254/5985/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2696239
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2695918
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[makortel]

@cmsbuil, please test

Let's try again

[cmsbuild]

+1
Tested at: 941d584
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bf254/6140/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3bf254/6140/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697206
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[makortel]

+1

[jfernan2]

+1

[peruzzim]

+xpog

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1