MTD geometry: porting of MTDNumberingBuilder to DD4hep #29647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29647/15040
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
@smuzaffar hard to notice any visible difference in the proposed patch... |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29647/15041
|
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages: Geometry/MTDCommonData @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@silviodonato @kpedro88 as you notice this PR embeds #29599. If that can be merged as it is (it should IMO) I will rebase this one, otherwise better to close that and continue here in case. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29647/15308
|
|
Pull request #29647 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
The reported failure in CMSSW code rules is unrelated to this PR, DQM differences are unrelated as well |
|
+upgrade |
|
merge |
|
+1 |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR builds on top of #29599 and previous developments a porting of
Geometry/MTDNumberingBuilderto DD4hep. In order to accomplish this task, additionalSpecParshave been added inmtdStructureTopologyto specify the list of volumes to be considered in the loop to build subdetectors, layers and modules. The names of BTL Layer1 and ETL discs have been extended with the addition of theTimingsuffix to distinguish them from the tracker subvolumes, and resolve an ambiguity that DDCMS at present seems unable to handle (as reported to @ianna). The DDD code has been updated accordingly.Non negligible memory issues have been noticed with the
navPos()method of DDCMS in this porting, and its use has been dropped from everywhere, and it is not used to fillGeometricTimingDet, as it looks like this information is not anyway used afterwards (this was carbon-coped from tracker). They can be seen just adding the print offv->navPos().size()in the new test added inDDCMSfor thecms::DDFilteredView.The porting to DD4hep tries to:
use the FilteredView philosophy based on SpecPar selection, avoiding a full loop based on
fv.next(0);keep the loop on the entire geometry inside a single method, avoiding nested calls to different levels as done in the Tracker geometry;
circumvent the nested filling of
GeometricTimingDetcontainers by using intermediate temporarysubdetandlayervectors. For the time being the bare pointer original structure of the containers has been kept to minimize simultaneous changes and disruption.PR validation:
The test configuration in
Geometry/MTDNumberingBuilderruns on both scenario D50 and D53, providing identical lists of detIds. The DDD version is unchanged compared to the base reference. Differences in rotation matrices are due to the sign of terms that are null up to the 6th decimal digit. The calculation ofPhilooks different for the top level volumes, but I believe this might be an artefact of translation vectors along the z direction. No difference is observed for modules.The
Geometry/MTDGeometryBuildertests have been updated, they give the same result as before for DDD, there is a factor of 10 to be fixed in next developments for DD4hep.