Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up BuildFiles under CommonTools/ #29654

Merged
merged 1 commit into from May 6, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

Clean up BuildFile.xml filea with `xmllint --format`.
@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29654/15053

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6021/console Started: 2020/05/05 14:21

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

CommonTools/BaseParticlePropagator
CommonTools/CandAlgos
CommonTools/CandUtils
CommonTools/Clustering1D
CommonTools/MVAUtils
CommonTools/ParticleFlow
CommonTools/PileupAlgos
CommonTools/RecoAlgos
CommonTools/RecoUtils
CommonTools/Statistics
CommonTools/TrackerMap
CommonTools/TriggerUtils
CommonTools/UtilAlgos
CommonTools/Utils

@perrotta, @andrius-k, @lveldere, @kmaeshima, @civanch, @sbein, @schneiml, @ssekmen, @mdhildreth, @cmsbuild, @jfernan2, @fioriNTU, @slava77, @santocch can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @riga, @abbiendi, @jhgoh, @makortel, @gkasieczka, @hatakeyamak, @venturia, @threus, @clelange, @cbernet this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+1
Tested at: 03cf3db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-105baf/6021/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-105baf/6021/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-105baf/6021/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-105baf/6021/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695919
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented May 6, 2020

+1
Changes due to #29628

@perrotta
Copy link
Contributor

perrotta commented May 6, 2020

+1

  • Technical
  • Changes are only in white spaces and empty lines
  • Jenkins tests pass
  • (Trying to clean up the queue of pendig pull requests for reconstruction)
  • "DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates" due to testing this together with Added particle flow candidates to particle flow validation #29628

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 1e86f50 into cms-sw:master May 6, 2020
@santocch
Copy link

santocch commented May 7, 2020

+1

@fwyzard fwyzard deleted the branch_lintBuildFile_CommonTools branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants