Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up BuildFiles under EgammaAnalysis/ #29669

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

Clean up BuildFile.xml filea with `xmllint --format`.
@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29669/15069

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

EgammaAnalysis/ElectronTools

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@afiqaize, @jainshilpi, @Sam-Harper, @varuns23, @sobhatta this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 446adc7 into cms-sw:master May 6, 2020
@santocch
Copy link

santocch commented May 7, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

@fwyzard fwyzard deleted the branch_lintBuildFile_EgammaAnalysis branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants