Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up BuildFiles under Geometry/ #29675

Merged
merged 1 commit into from May 6, 2020
Merged

Clean up BuildFiles under Geometry/ #29675

merged 1 commit into from May 6, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented May 5, 2020

Clean up BuildFile.xml filea with xmllint --format.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 5, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29675/15075

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6044/console Started: 2020/05/05 17:28

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

Geometry/CMSCommonData
Geometry/CSCGeometry
Geometry/CSCGeometryBuilder
Geometry/CaloEventSetup
Geometry/CaloGeometry
Geometry/CaloTopology
Geometry/CommonDetUnit
Geometry/CommonTopologies
Geometry/DTGeometry
Geometry/DTGeometryBuilder
Geometry/EcalAlgo
Geometry/EcalCommonData
Geometry/EcalMapping
Geometry/EcalTestBeam
Geometry/ForwardCommonData
Geometry/ForwardGeometry
Geometry/GEMGeometry
Geometry/GEMGeometryBuilder
Geometry/GlobalTrackingGeometryBuilder
Geometry/HGCalCommonData
Geometry/HGCalGeometry
Geometry/HcalAlgo
Geometry/HcalCommonData
Geometry/HcalEventSetup
Geometry/HcalTestBeamData
Geometry/HcalTowerAlgo
Geometry/MTCCTrackerCommonData
Geometry/MTDCommonData
Geometry/MTDGeometryBuilder
Geometry/MTDNumberingBuilder
Geometry/MuonCommonData
Geometry/MuonNumbering
Geometry/RPCGeometry
Geometry/RPCGeometryBuilder
Geometry/Records
Geometry/TrackerCommonData
Geometry/TrackerGeometryBuilder
Geometry/TrackerNumberingBuilder
Geometry/VeryForwardGeometry
Geometry/VeryForwardGeometryBuilder
Geometry/VeryForwardRPTopology

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@battibass, @makortel, @forthommel, @jan-kaspar, @argiro, @ghugo83, @jshlee, @dildick, @vargasa, @ptcox, @ebrondol, @VinInn, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild cmsbuild mentioned this pull request May 5, 2020
Closed
@fwyzard fwyzard force-pushed the branch_lintBuildFile_Geometry branch from 269e04d to 3f03120 Compare May 5, 2020 17:02
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@fwyzard
Clean up BuildFiles under Geometry/
e91a8d3 
Clean up BuildFile.xml filea with `xmllint --format`.
@fwyzard fwyzard force-pushed the branch_lintBuildFile_Geometry branch from 3f03120 to e91a8d3 Compare May 5, 2020 17:04
@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented May 5, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29675/15155

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6118/console Started: 2020/05/05 22:53

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Pull request #29675 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

-1

Tested at: 269e04d

CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6a61e/6044/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6a61e/6044/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6a61e/6044/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found compilation error when building:

/cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/Geometry/RPCGeometry/src/GeometryRPCGeometry/RPCRoll.cc.o:(.data.rel.ro._ZTV7RPCRoll[_ZTV7RPCRoll]+0x60): undefined reference to `GeomDet::setSurfaceDeformation(SurfaceDeformation const*)'
/cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/Geometry/RPCGeometry/src/GeometryRPCGeometry/RPCGeometry.cc.o: in function `RPCGeometry::chamber(RPCDetId) const':
RPCGeometry.cc:(.text+0x398): undefined reference to `typeinfo for GeomDet'
/cvmfs/cms-ib.cern.ch/nweek-02627/slc7_amd64_gcc820/external/gcc/8.2.0-pafccj/bin/../lib/gcc/x86_64-unknown-linux-gnu/8.3.1/../../../../x86_64-unknown-linux-gnu/bin/ld: tmp/slc7_amd64_gcc820/src/Geometry/RPCGeometry/src/GeometryRPCGeometry/RPCGeometry.cc.o: in function `RPCGeometry::roll(RPCDetId) const':
RPCGeometry.cc:(.text+0x3c9): undefined reference to `typeinfo for GeomDet'
collect2: error: ld returned 1 exit status
gmake: *** [tmp/slc7_amd64_gcc820/src/Geometry/RPCGeometry/src/GeometryRPCGeometry/libGeometryRPCGeometry.so] Error 1
Leaving library rule at Geometry/RPCGeometry
Entering library rule at src/Geometry/RPCGeometry/test
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_1_X_2020-05-05-1100/src/Geometry/RPCGeometry/test/RPCGEO2.cc 
>> Building edm plugin tmp/slc7_amd64_gcc820/src/Geometry/RPCGeometry/test/testGeometryRPCGEO2/libtestGeometryRPCGEO2.so

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6a61e/6044/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6a61e/6044/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2020

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

+1
Tested at: e91a8d3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6a61e/6118/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6a61e/6118/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6a61e/6118/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c6a61e/6118/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2696239
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2695918
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 495.627 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 21.549 KiB ParticleFlow/PackedCandidates
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cmsbuild cmsbuild mentioned this pull request May 6, 2020
Merged
@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 4371ff3 into cms-sw:master May 6, 2020
@cvuosalo
Copy link
Contributor

cvuosalo commented May 6, 2020

+1

@cmsbuild cmsbuild mentioned this pull request May 6, 2020
Merged
@fwyzard fwyzard deleted the branch_lintBuildFile_Geometry branch May 8, 2020 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available geometry-approved orp-approved pending-signatures tests-approved upgrade-pending
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fwyzard @cmsbuild @silviodonato @cvuosalo