DQM: Clean up DQMServices/Core and its usages

[schneiml]

PR description:

While working on the test for #29738, I saw that we have still a lot of obsolete options set on the DQMStore. Cleaning that up got a bit out of hand, so therefore a separate PR here.

• All files in DQMServices/Core now have a well defined, up to date purpose.
  • I removed some old headers (+usages of DQMError), DQMOldReciever (from run 1, i think?), the ever-empty doc/ folder
  • I also removed the tests in DQMServices/Core, primarily because the are not set up in scram, so it's not clear how to use them and they might not work any more. Many of them also tested obsolete and removed features.
  • Finally, I removed the "standalone" mode. We gave up supporting it a while ago already. DQMGUI will keep using its CMSSW7 version of DQMStore for the future.
• I removed all usages of forceReset*, enableMultiThread, referenceFileName, and collateHistograms options on the DQMStore across all of CMSSW. The DQMStore stopped using these options a while ago. This affects multiple categories of files:
  • Random, potentially obsolete and hard-to-test configs. We could leave them unchanged for historical value, but I think that would be more confusing.
  • Online DQM. The referenceFileName there was (maybe?) actually still used in last collisions data taking, but we decided to remove the references entirely anyways.
  • Production offline and HLT configs. These are pretty important.

PR validation:

Not much. Needs more testing.

By construction everything removed here was no longer respected anyways, so nothing should change anywhere. But the changes do affect some important code that I have very little understanding of, so there may be side effects.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29742/15153

• This PR adds an extra 2380KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQMServices/Core/BuildFile.xml modified in PR(s): Clean up BuildFiles under DQMServices/ #29668
  • File DQMServices/Core/test/BuildFile.xml modified in PR(s): Clean up BuildFiles under DQMServices/ #29668
  • File DQMServices/Demo/test/run_analyzers_cfg.py modified in PR(s): DQM: Fix empty lumis with per-lumi plots in DQMOneEDAnalyzer #29738

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29742/15153/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29742/15153/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29742/15173

• This PR adds an extra 2404KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQMServices/Core/BuildFile.xml modified in PR(s): Clean up BuildFiles under DQMServices/ #29668
  • File DQMServices/Core/test/BuildFile.xml modified in PR(s): Clean up BuildFiles under DQMServices/ #29668

[cmsbuild]

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

CalibMuon/DTCalibration
CalibTracker/SiStripChannelGain
CalibTracker/SiStripESProducers
Calibration/EcalCalibAlgos
Calibration/TkAlCaRecoProducers
Configuration/DataProcessing
Configuration/StandardSequences
DQM/CSCMonitorModule
DQM/DTMonitorModule
DQM/HLTEvF
DQM/Integration
DQM/L1TMonitor
DQM/Physics
DQM/SiPixelMonitorClient
DQM/SiPixelMonitorTrack
DQM/SiStripMonitorClient
DQM/SiStripMonitorDigi
DQM/SiStripMonitorPedestals
DQM/SiStripMonitorSummary
DQM/SiStripMonitorTrack
DQM/TrackingMonitor
DQM/TrigXMonitor
DQMOffline/Alignment
DQMOffline/CalibMuon
DQMOffline/CalibTracker
DQMOffline/JetMET
DQMOffline/L1Trigger
DQMOffline/Trigger
DQMServices/Components
DQMServices/Core
DQMServices/Demo
DQMServices/Examples
DQMServices/FileIO
DQMServices/FwkIO
EventFilter/Utilities
HLTrigger/Configuration
HLTrigger/Timer
HLTriggerOffline/B2G
HLTriggerOffline/Btag
HLTriggerOffline/Common
HLTriggerOffline/Exotica
HLTriggerOffline/HeavyFlavor
HLTriggerOffline/Higgs
HLTriggerOffline/Muon
HLTriggerOffline/SMP
HLTriggerOffline/SUSYBSM
L1Trigger/RPCTrigger
Validation/CaloTowers
Validation/Configuration
Validation/HGCalValidation
Validation/HcalHits
Validation/Mixing
Validation/RPCRecHits
Validation/RecoB
Validation/RecoMuon
Validation/RecoParticleFlow
Validation/RecoTau
Validation/RecoTrack
Validation/RecoVertex
Validation/TrackerConfiguration

@andrius-k, @christopheralanwest, @schneiml, @Martin-Grunewald, @rekovic, @fioriNTU, @tlampen, @pohsun, @perrotta, @civanch, @silviodonato, @cmsbuild, @fwyzard, @davidlange6, @mdhildreth, @jfernan2, @tocheng, @slava77, @mommsen, @fabiocos, @benkrikler, @kmaeshima, @emeschi, @franzoni can you please review it and eventually sign? Thanks.
@wmtford, @echabert, @rappoccio, @apsallid, @felicepantaleo, @slomeo, @jandrea, @robervalwalsh, @emilbols, @argiro, @Martin-Grunewald, @bsunanda, @pfs, @ahinzmann, @lgray, @threus, @mmusich, @seemasharmafnal, @venturia, @mmarionncern, @kreczko, @sethzenz, @JyothsnaKomaragiri, @makortel, @abdoulline, @mverzett, @jhgoh, @dgulhan, @jdolen, @HuguesBrun, @cericeci, @ferencek, @pieterdavid, @rociovilar, @vandreev11, @abbiendi, @barvic, @GiacomoSguazzoni, @tocheng, @VinInn, @cseez, @missirol, @nhanvtran, @gkasieczka, @rovere, @deguio, @schoef, @alesaggio, @idebruyn, @ebrondol, @ptcox, @mtosi, @fabiocos, @clelange, @jdamgov, @batinkov, @hdelanno, @trocino, @battibass, @gbenelli, @Fedespring, @calderona, @hatakeyamak, @lecriste, @smoortga, @mariadalfonso, @andrzejnovak, @folguera, @fioriNTU this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6130/console Started: 2020/05/06 10:14

[cmsbuild]

+1
Tested at: 00d437d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dcb113/6130/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

[schneiml]

+1

There are no changes out of the background noise (as expected), and as far as I remember the concerns are adressed.

[perrotta]

+1

• Reconstruction only involved because ot the removal of a few obsolete parameters from a couple of unit tests in EventFilter/Utilities
• Jenkins tests pass

[mommsen]

@srecko, could you please have a look at the DQM changes affecting online, i.e. EventFilter/Utilities/test/startFU.py and EventFilter/Utilities/test/unittest_FU.py, and if there is some side effect of these changes?

[Martin-Grunewald]

+1

[civanch]

+1

[silviodonato]

+operations

[silviodonato]

Do you have any objections?
l1: @benkrikler @rekovic
alca: @pohsun @tlampen @tocheng @christopheralanwest

[rekovic]

+1

[pohsun]

+1

[silviodonato]

merge
FYI daq: @emeschi @mommsen