Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eventcontent structure for RecoHiEgamma #29746

Merged
merged 3 commits into from May 13, 2020
Merged

Update eventcontent structure for RecoHiEgamma #29746

merged 3 commits into from May 13, 2020

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented May 6, 2020

PR description:

Update event content definitions to explicitly have RECO to be a superset of AOD and for FEVT to be a superset of RECO. 1 file changed :

  • RecoHI/HiEgammaAlgos/python/RecoHiEgamma_EventContent_cff.py

(The previous tasks for RecoHI event content is PR#29576 )

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_1_X, the basic test all passed in the CMSSW PR instructions.

@cmsbuild cmsbuild added this to the CMSSW_11_1_X milestone May 6, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29746/15175

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoHI/HiEgammaAlgos

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented May 6, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6134/console Started: 2020/05/06 14:22

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

+1
Tested at: 89ee79b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4cdd/6134/summary.html
CMSSW: CMSSW_11_1_X_2020-05-05-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison job queued.

@perrotta
Copy link
Contributor

perrotta commented May 6, 2020

@mandrenguyen FYI

perrotta
perrotta reviewed May 6, 2020
View reviewed changes
RecoHI/HiEgammaAlgos/python/RecoHiEgamma_EventContent_cff.py Outdated
'keep EESrFlagsSorted_ecalDigis__*',
'keep recoPFCandidates_particleFlowEGamma_*_*',
'keep recoPFCandidates_particleFlowTmp_*_*',
"drop recoPFClusters_*_*_*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useless, are you as not keeping it anywhere here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Okay, I'll remove the drop (L64).
And I'd like to notice to you that there are more things to be fixed.
I've realized that the floatedmValueMap_hi*(L7-17) is not in the AOD event content, is in the RECO/FEVT event content.
So I'll fix it and also remove some unused modules (not found in the event content list from HI workflows output) in RecoHiEgammaRECO.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4cdd/6134/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697206
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@silviodonato
Copy link
Contributor

Status: waiting for an update of the PR.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29746/15329

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #29746 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 12, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6262/console Started: 2020/05/12 23:03

@cmsbuild
Copy link
Contributor

+1
Tested at: 5aa000b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4cdd/6262/summary.html
CMSSW: CMSSW_11_1_X_2020-05-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a4cdd/6262/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2697527
  • DQMHistoTests: Total failures: 26
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2697182
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

+1

  • Event contents refactored according to the plans
  • Also a bug in the RECO event content got fixed, incidentally (recoSuperCluster instead of recoSuperClusters): evidently that RECO event content was never used before for RecoHiEgamma
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e636760 into cms-sw:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jeongeun @cmsbuild @perrotta @silviodonato