Run3-ft16 Beampipe and forward shield for run3 geometry

[bsunanda]

PR description:

Beampipe and forward shield for run3 geometry

PR validation:

Tested for overlaps

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29809/15312

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • Geometry/CMSCommonData/data/cmsBeam/2021/v1/cmsBeam.xml:
    • Added: 5fd5413
    • Deleted: 8d339e0

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Geometry/CMSCommonData
Geometry/ForwardCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6247/console Started: 2020/05/12 14:54

[cmsbuild]

+1
Tested at: 8d339e0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d06ba/6247/summary.html
CMSSW: CMSSW_11_1_X_2020-05-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d06ba/6247/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 42
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697166
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[civanch]

@bsunanda , @cvuosalo , @ianna , do we need beampipe/v2 and cms/v4 when we do not make modifications in the DB? Simply v1 and v3 may be updated.

If we keep this modification as new files, then in this PR they should be included into the main XML file.

[bsunanda]

I do not mind to move the changes to v1 and v3. But still the run3 cfi needs to be modified. That I shall do once things get settled for this.

[cvuosalo]

Since the new 2021 geometry DB payloads have not been created yet, we should be changing the existing versions for 2021 and not bumping up the version numbers. The existing versions are still in progress and have not been frozen.

[cmsbuild]

The code-checks are being triggered in jenkins.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29809/15324

• This PR adds an extra 28KB to repository

• Found files with invalid states:

  • Geometry/CMSCommonData/data/beampipe/2021/v2/beampipe.xml:
    • Added: 5fd5413
    • Deleted: edcd063
  • Geometry/CMSCommonData/data/cms/2021/v4/cms.xml:
    • Added: 5fd5413
    • Deleted: edcd063
  • Geometry/CMSCommonData/data/cmsBeam/2021/v1/cmsBeam.xml:
    • Added: 5fd5413
    • Deleted: 8d339e0

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6258/console Started: 2020/05/12 20:48

[cmsbuild]

Pull request #29809 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

[cmsbuild]

+1
Tested at: edcd063
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d06ba/6258/summary.html
CMSSW: CMSSW_11_1_X_2020-05-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d06ba/6258/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2697527
• DQMHistoTests: Total failures: 41
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2697167
• DQMHistoTests: Total skipped: 319
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[kpedro88]

+upgrade

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1