Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecHit map and CaloParticle-LayerCluster associator #29844

Merged
merged 48 commits into from May 26, 2020

Conversation

lecriste
Copy link
Contributor

PR description:

This PR introduces two products (a std::map and an associator) which can be consumed by several analyzers, removing code duplication. The first replacement is made for the HGVHistoProducerAlgo::fill_generic_cluster_histos method, no changes are expected in the output.

PR validation:

runTheMatrix -l limited

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7963d/6507/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2694466
  • DQMHistoTests: Total failures: 42
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2694375
  • DQMHistoTests: Total skipped: 49
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 150 log files, 16 edm output root files, 35 DQM output files

@jfernan2
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+upgrade

some improvements (e.g. use of unordered_map) will be addressed in followup PR

@slava77
Copy link
Contributor

slava77 commented May 22, 2020

+1

for #29844 fc6c8aa

  • no changes in reco files since the last signoff (the latest update was in a follow up to my comment though, Thanks!)

@civanch
Copy link
Contributor

civanch commented May 23, 2020

+1

@silviodonato
Copy link
Contributor

Do you have any comments? core: @Dr15Jones @makortel @smuzaffar

@makortel
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet