New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-ft20 Modify eras and cff's to accommodate steps using dd4hep #29909
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29909/15503
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Configuration/Eras @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @kpedro88, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
from Configuration.Eras.Era_Run3_cff import Run3 | ||
from Configuration.ProcessModifiers.dd4hep_cff import dd4hep | ||
|
||
Run3_dd4hep = cms.ModifierChain(Run3, dd4hep) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add this in Configuration/StandardSequences/python/Eras.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@kpedro88 Could you sign this please? |
+upgrade |
@silviodonato Can this PR be integrated because that will help testing dd4hep definitions for Run3 geometry |
@civanch Could you make this Urgent as well. Without this one cannot test dd4hep applications |
urgent |
+operations |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Modify eras and cff's to accommodate steps using dd4hep
PR validation:
Use runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special