Allow DDNames to be created concurrently

[Dr15Jones]

PR description:

In order to support concurrent running of ES modules we need to be able to concurrently create DDNames. This change replaces the global containers being used with tbb concurrent containers.

PR validation:

The code compiles and all unit tests in DetectorDescription/Core pass.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29956/15609

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DetectorDescription/Core

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6520/console Started: 2020/05/22 19:13

[cmsbuild]

+1
Tested at: 3d9aeba
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fda61/6520/summary.html
CMSSW: CMSSW_11_1_X_2020-05-22-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cvuosalo]

@Dr15Jones How urgent is this change? We are in the midst of DD4hep migration, and we would like to keep the old code like this unchanged to avoid validation problems. If both the old DD and DD4hep code are changing at the same time, it becomes hard to understand differing results between them.

[Dr15Jones]

This change should have absolutely no difference. And it is fairly urgent since I have the code to allow concurrent ES modules to run.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4fda61/6520/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 52
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780690
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[cvuosalo]

@ianna Could you please review this change? I would like to be sure it doesn't cause any inadvertent changes.

[ianna]

+1

no adverse effect of this change

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1