New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCal] Validation scripts and code for RelVal campaigns #29977
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29977/15643
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29977/15646
|
A new Pull Request was created by @apsallid for master. It involves the following packages: Validation/HGCalValidation @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR contains code we (@rovere, @felicepantaleo, @lecriste) developed and tested in order to create the validation reports for the regular RelVal campaigns.
The workflow for a validation report is fully documented in [1], where the code is also described in more detail.
You will spot some commented code in the RelVal sample list as well as in a few commands, which we would like to keep. The RelVal list is under constant review (e.g CloseByParticleGun samples are really helpful but not unfortunately in pre7 or after pre4 and only produced in pre6), while certain strings in the "raw" campaigns are slightly changing each time and some tweaks are necessary.
This work is based on and inspired from the Tracker validation work.
These scripts can also be used for a custom validation of certain new features and compared with the RelVal samples of the latest pre-release.
Also, after the introduction of TICL, we update the
hgcalPlots.py
with the correct path where the plots of the relevant objects lives in the DQM files.PR validation:
The code in this PR has been used for the validation reports in campaigns from 11_1_0_pre4_phase2 until this week pre7 campaigns and all results are placed in a dedicated webpage [2].
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is not a backport.
[1] http://hgcal.web.cern.ch/hgcal/Validation/RelVals/
[2] http://cms-hgcal-validation.web.cern.ch/cms-hgcal-validation/