Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCal] Validation scripts and code for RelVal campaigns #29977

Merged
merged 7 commits into from May 25, 2020

Conversation

apsallid
Copy link
Contributor

@apsallid apsallid commented May 25, 2020

PR description:

This PR contains code we (@rovere, @felicepantaleo, @lecriste) developed and tested in order to create the validation reports for the regular RelVal campaigns.

The workflow for a validation report is fully documented in [1], where the code is also described in more detail.

You will spot some commented code in the RelVal sample list as well as in a few commands, which we would like to keep. The RelVal list is under constant review (e.g CloseByParticleGun samples are really helpful but not unfortunately in pre7 or after pre4 and only produced in pre6), while certain strings in the "raw" campaigns are slightly changing each time and some tweaks are necessary.

This work is based on and inspired from the Tracker validation work.

These scripts can also be used for a custom validation of certain new features and compared with the RelVal samples of the latest pre-release.

Also, after the introduction of TICL, we update the hgcalPlots.py with the correct path where the plots of the relevant objects lives in the DQM files.

PR validation:

The code in this PR has been used for the validation reports in campaigns from 11_1_0_pre4_phase2 until this week pre7 campaigns and all results are placed in a dedicated webpage [2].

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport.

[1] http://hgcal.web.cern.ch/hgcal/Validation/RelVals/

[2] http://cms-hgcal-validation.web.cern.ch/cms-hgcal-validation/

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29977/15643

  • This PR adds an extra 44KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29977/15646

  • This PR adds an extra 44KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apsallid for master.

It involves the following packages:

Validation/HGCalValidation

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@vandreev11, @deguio, @sethzenz, @rovere, @lgray, @cseez, @bsunanda, @pfs, @lecriste, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6562/console Started: 2020/05/25 14:39

@cmsbuild
Copy link
Contributor

+1
Tested at: e45afdc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f248f9/6562/summary.html
CMSSW: CMSSW_11_2_X_2020-05-24-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f248f9/6562/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 49
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780693
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 34d2bfd into cms-sw:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants