Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix to runTauIdMVA.py tool (11_1_X) #29978

Merged

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented May 25, 2020

PR description:

This PR fixes bugs introduced to runTauIdMVA.py tool during implementation of the new tauID dataformat #28417.

It is backport of #29976 to 11_1_X

PR validation:

This tool is not used in standard workflows except miniAOD (to include deepTauID) which uses its non-affected part. Therefore, the fix was tested with RecoTauTag/RecoTau/test/runDeepTauIDsOnMiniAOD.py test configuration. This test configuration is added to units tests in this PR.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #29976 (This PR shares development branch with the PR to master)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 25, 2020

A new Pull Request was created by @mbluj for CMSSW_11_1_X.

It involves the following packages:

RecoTauTag/RecoTau

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@riga this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #29978 was updated. @perrotta, @cmsbuild, @fgolf, @slava77, @santocch, @peruzzim can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented May 27, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 27, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6610/console Started: 2020/05/27 02:52

@slava77
Copy link
Contributor

slava77 commented May 27, 2020

+1

for #29978 7aaf1ab

  • this is identical to the 11_2_X version (the same topic branch is used)
  • this PR should be safe for a backport: the update affects only a part of the code still used for analysis; the part used in production has only a technical "formatting" change (self. was dropped)

@slava77
Copy link
Contributor

slava77 commented May 27, 2020

backport of #29976

@cmsbuild
Copy link
Contributor

+1
Tested at: 7aaf1ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c6049/6610/summary.html
CMSSW: CMSSW_11_1_X_2020-05-26-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c6049/6610/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 35
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780707
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@santocch
Copy link

+1

@silviodonato
Copy link
Contributor

Do you have any comments @peruzzim ?

@silviodonato
Copy link
Contributor

merge
cc: @peruzzim

@cmsbuild cmsbuild merged commit a435e1a into cms-sw:CMSSW_11_1_X Jun 3, 2020
@mbluj mbluj deleted the CMSSW_11_1_X_tau-pog_TauIdToolFix branch October 10, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants