New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specific friendly names for unordered_set and unordered_map #29987
Add specific friendly names for unordered_set and unordered_map #29987
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29987/15659
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/Utilities @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
@Dr15Jones please review |
The tests are being triggered in jenkins. |
@@ -37,6 +37,10 @@ void testfriendlyName::test() { | |||
classToFriendly.insert(Values("bar::Foo", "barFoo")); | |||
classToFriendly.insert(Values("std::vector<Foo>", "Foos")); | |||
classToFriendly.insert(Values("std::vector<bar::Foo>", "barFoos")); | |||
classToFriendly.insert(Values("std::set<bar::Foo>", "barFoostdset")); | |||
classToFriendly.insert(Values("std::map<Foo, bar::Bar>", "FoobarBarstdmap")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added these two just to test the current behavior with std::set
and std::map
.
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Comparison job queued. |
+1 |
Comparison is ready Comparison Summary:
|
PR description:
This PR adds specific friendly class names for
std::unordered_set
andstd::unordered_map
to avoid underscores in their friendly class names. Resolves #29967.PR validation:
Unit test passes.