adapt Pythia8Interface to pythia8 302 (PR cmsdist #5869, to be tested together) #29995

mkirsano · 2020-05-27T08:11:09Z

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-05-27T08:11:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-27T08:19:39Z

-code-checks

ERROR: Build errors found during clang-tidy run.

GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc:14:16: error: too few arguments to function call, expected 5, have 0 [clang-diagnostic-error]
  decayer.init();
               ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8/TauDecays.h:38:3: note: 'init' declared here
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:346:30: error: calling a private constructor of class 'Pythia8::UserHooksVector' [clang-diagnostic-error]
  fUserHooksVector.reset(new UserHooksVector);
                             ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8/UserHooks.h:334:3: note: declared private here
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:349:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fReweightUserHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<UserHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:351:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fReweightEmpUserHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<UserHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:353:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fReweightRapUserHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<UserHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:355:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fReweightPtHatRapUserHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<UserHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:357:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fJetMatchingHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<JetMatchingHook>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:360:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fEmissionVetoHook1);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<EmissionVetoHook1>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:372:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fEmissionVetoHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<PowhegHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:379:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fPowhegResHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<PowhegResHook>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:386:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fPowhegHooksBB4L);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<PowhegHooksBB4L>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:222:1: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
EvtGenDecays::EvtGenDecays(Pythia *pythiaPtrIn, string decayFile,
^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:282:8: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
double EvtGenDecays::decay() {
       ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:385:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
void EvtGenDecays::updatePythia() {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:408:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
void EvtGenDecays::updateEvtGen() {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:433:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
void EvtGenDecays::updateData(bool final) {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:524:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
void EvtGenDecays::updateEvent(Particle *pyPro, EvtParticle *egPro,
     ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:582:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
bool EvtGenDecays::checkVertex(Particle *pyPro) {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:597:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
bool EvtGenDecays::checkSignal(Particle *pyPro) {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:611:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
bool EvtGenDecays::checkOsc(EvtParticle *egPro) {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02630/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

mkirsano · 2020-05-27T08:29:33Z

To be tested together with PR cmsdist #5869 (including code-checks)

silviodonato · 2020-06-01T15:35:36Z

code-checks

cmsbuild · 2020-06-01T15:36:02Z

The code-checks are being triggered in jenkins.

silviodonato · 2020-06-01T15:37:23Z

@mkirsano please update the pull request in order to pass the code checks above

cmsbuild · 2020-06-01T15:41:31Z

+code-checks
@smuzaffar has by passed this check as this needs an external to run the code-checks

ERROR: Build errors found during clang-tidy run.

GeneratorInterface/Pythia8Interface/src/BiasedTauDecayer.cc:14:16: error: too few arguments to function call, expected 5, have 0 [clang-diagnostic-error]
  decayer.init();
               ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8/TauDecays.h:38:3: note: 'init' declared here
--
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:222:1: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
EvtGenDecays::EvtGenDecays(Pythia *pythiaPtrIn, string decayFile,
^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:282:8: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
double EvtGenDecays::decay() {
       ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:385:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
void EvtGenDecays::updatePythia() {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:408:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
void EvtGenDecays::updateEvtGen() {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:433:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
void EvtGenDecays::updateData(bool final) {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:524:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
void EvtGenDecays::updateEvent(Particle *pyPro, EvtParticle *egPro,
     ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:582:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
bool EvtGenDecays::checkVertex(Particle *pyPro) {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:597:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
bool EvtGenDecays::checkSignal(Particle *pyPro) {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:611:6: error: reference to 'EvtGenDecays' is ambiguous [clang-diagnostic-error]
bool EvtGenDecays::checkOsc(EvtParticle *egPro) {
     ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8Plugins/EvtGen.h:87:7: note: candidate found by name lookup is 'EvtGenDecays'
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:346:30: error: calling a private constructor of class 'Pythia8::UserHooksVector' [clang-diagnostic-error]
  fUserHooksVector.reset(new UserHooksVector);
                             ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/pythia8/243-bcolbf2/include/Pythia8/UserHooks.h:334:3: note: declared private here
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:349:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fReweightUserHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<UserHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:351:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fReweightEmpUserHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<UserHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:353:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fReweightRapUserHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<UserHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:355:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fReweightPtHatRapUserHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<UserHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:357:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fJetMatchingHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<JetMatchingHook>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:360:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fEmissionVetoHook1);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<EmissionVetoHook1>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:372:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fEmissionVetoHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<PowhegHooks>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:379:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fPowhegResHook);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<PowhegResHook>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
GeneratorInterface/Pythia8Interface/plugins/Pythia8Hadronizer.cc:386:31: error: no matching member function for call to 'push_back' [clang-diagnostic-error]
    (fUserHooksVector->hooks).push_back(fPowhegHooksBB4L);
                              ^
/cvmfs/cms-ib.cern.ch/nweek-02631/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_vector.h:1074:7: note: candidate function not viable: no known conversion from 'std::shared_ptr<PowhegHooksBB4L>' to 'const std::vector<Pythia8::UserHooks *, std::allocator<Pythia8::UserHooks *> >::value_type' (aka 'Pythia8::UserHooks *const') for 1st argument
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

cmsbuild · 2020-06-01T15:45:13Z

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for master.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2020-06-01T15:45:23Z

test parameters

pull_requests = upgrade pythia8 to 302 cmsdist#5869

smuzaffar · 2020-06-01T15:45:29Z

please test

cmsbuild · 2020-06-01T15:45:37Z

The tests are being triggered in jenkins.
Tested with other pull request(s) cms-sw/cmsdist#5869
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6720/console Started: 2020/06/01 17:46

cmsbuild · 2020-06-01T18:06:33Z

+1
Tested at: b7ef199
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c30f/6720/summary.html
CMSSW: CMSSW_11_2_X_2020-06-01-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-01T18:06:38Z

Comparison job queued.

cmsbuild · 2020-06-01T21:52:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e3c30f/6720/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 44070 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2782598
DQMHistoTests: Total failures: 426577
DQMHistoTests: Total nulls: 6
DQMHistoTests: Total successes: 2355965
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -529.394 KiB( 35 files compared)
DQMHistoSizes: changed ( 10224.0 ): 0.352 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 11634.0,... ): -265.416 KiB HLT/HLTEgammaValidation
DQMHistoSizes: changed ( 250202.181 ): 0.420 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.666 KiB SiStrip/MechanicalView
Checked 152 log files, 16 edm output root files, 36 DQM output files

silviodonato · 2020-06-08T13:53:48Z

what is the status of this PR and cms-sw/cmsdist#5869?
@mkirsano, @SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez, @qliphy

mkirsano · 2020-06-09T07:46:20Z

Discussed yesterday at the GEN meeting. Decision to be taken.

mkirsano · 2020-06-10T15:50:05Z

+1

cmsbuild · 2020-06-10T15:50:32Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-06-11T08:16:42Z

+1

smuzaffar · 2020-06-11T15:06:08Z

@mkirsano , looks like this broke at least one relval ( 1361.181 )

[a]
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc820/CMSSW_11_2_X_2020-06-11-1100/pyRelValMatrixLogs/run/1361.181_GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP18ml+GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP18ml+DIGIUP18ml+RECOUP18ml+HARVESTUP18+NANOUP18ml/step1_GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP18ml+GluGluHToZZTo4L_M125_Pow_py8_Evt_13UP18ml+DIGIUP18ml+RECOUP18ml+HARVESTUP18+NANOUP18ml.log#/9302-9310

#5  0x00002ba9f8fdcb7c in Pythia8::PhysicsBase::beginEvent() [clone .localalias.28] () from /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-11-1100/external/slc7_amd64_gcc820/lib/libpythia8.so
#6  0x00002ba9f9014dac in Pythia8::Pythia::beginEvent() () from /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-11-1100/external/slc7_amd64_gcc820/lib/libpythia8.so
#7  0x00002ba9f901d9d9 in Pythia8::Pythia::next() () from /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-11-1100/external/slc7_amd64_gcc820/lib/libpythia8.so
#8  0x00002ba9f792486b in Pythia8Hadronizer::hadronize() () from /cvmfs/cms-ib.cern.ch/nweek-02632/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-06-11-1100/lib/slc7_amd64_gcc820/pluginGeneratorInterfacePythia8Filters.so

adapt interface to pythia8 302

b7ef199

cmsbuild added this to the CMSSW_11_2_X milestone May 27, 2020

cmsbuild added code-checks-pending comparison-pending generators-pending orp-pending pending-signatures tests-pending labels May 27, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 27, 2020

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 1, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 1, 2020

mkirsano mentioned this pull request Jun 1, 2020

upgrade pythia8 to 302 cms-sw/cmsdist#5869

Merged

cmsbuild added code-checks-approved and removed code-checks-rejected labels Jun 1, 2020

cmsbuild added requires-external and removed tests-pending labels Jun 1, 2020

cmsbuild added the tests-started label Jun 1, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 1, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 1, 2020

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Jun 10, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 11, 2020

cmsbuild merged commit 4966b9e into cms-sw:master Jun 11, 2020

cmsbuild mentioned this pull request Jun 11, 2020

Delete GenTtbarCategorizer_cfi.py (already moved to fillDescription) #30193

Closed

silviodonato mentioned this pull request Jun 15, 2020

pythia8 version 302 is causing seg faults in WF 1361.181 #30234

Closed

mkirsano mentioned this pull request Jun 23, 2020

Fix Pythia8Interface adapted to pythia8 302 #30319

Merged

cericeci mentioned this pull request Dec 17, 2021

Backport of Factory for adding UserHooks to PythiaHadronizer and SUEP decay pythia Hook #36509

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adapt Pythia8Interface to pythia8 302 (PR cmsdist #5869, to be tested together) #29995

adapt Pythia8Interface to pythia8 302 (PR cmsdist #5869, to be tested together) #29995

mkirsano commented May 27, 2020

cmsbuild commented May 27, 2020

cmsbuild commented May 27, 2020

mkirsano commented May 27, 2020

silviodonato commented Jun 1, 2020

cmsbuild commented Jun 1, 2020

silviodonato commented Jun 1, 2020

cmsbuild commented Jun 1, 2020 •

edited by smuzaffar

cmsbuild commented Jun 1, 2020

smuzaffar commented Jun 1, 2020

smuzaffar commented Jun 1, 2020

cmsbuild commented Jun 1, 2020 •

edited

cmsbuild commented Jun 1, 2020

cmsbuild commented Jun 1, 2020

cmsbuild commented Jun 1, 2020

silviodonato commented Jun 8, 2020

mkirsano commented Jun 9, 2020

mkirsano commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

silviodonato commented Jun 11, 2020

smuzaffar commented Jun 11, 2020

adapt Pythia8Interface to pythia8 302 (PR cmsdist #5869, to be tested together) #29995

adapt Pythia8Interface to pythia8 302 (PR cmsdist #5869, to be tested together) #29995

Conversation

mkirsano commented May 27, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 27, 2020

cmsbuild commented May 27, 2020

mkirsano commented May 27, 2020

silviodonato commented Jun 1, 2020

cmsbuild commented Jun 1, 2020

silviodonato commented Jun 1, 2020

cmsbuild commented Jun 1, 2020 • edited by smuzaffar

cmsbuild commented Jun 1, 2020

smuzaffar commented Jun 1, 2020

smuzaffar commented Jun 1, 2020

cmsbuild commented Jun 1, 2020 • edited

cmsbuild commented Jun 1, 2020

cmsbuild commented Jun 1, 2020

cmsbuild commented Jun 1, 2020

silviodonato commented Jun 8, 2020

mkirsano commented Jun 9, 2020

mkirsano commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

silviodonato commented Jun 11, 2020

smuzaffar commented Jun 11, 2020

cmsbuild commented Jun 1, 2020 •

edited by smuzaffar

cmsbuild commented Jun 1, 2020 •

edited