Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.1.X] Add CDC Tracks to TkAlCosmics0T ALCARECO #30014

Merged
merged 1 commit into from Jun 1, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 28, 2020

backport of #30013

PR description:

In view of upcoming work foreseen on the Cosmics During Collisions (CDC) reconstruction, we add to the regular Tracker Alignment cosmics AlcaReco TkAlCosmics0T these tracks in order to have them produced during standard interfill, so that these can be used as "standard candle" for reconstruction optimization.
We provide also additional DQM monitoring for the newly added track collection.

PR validation:

This branch has been extensively used for privare re-recos of 2018 Data (see presentations from @skeshri here and here ) and also has gone through more technical validation via:

runTheMatrix.py -l 7.0,7.1,7.2,7.21,7.22,7.23,7.3,7.4 --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is a backport of #30013. It is requested in order to be able to ask larger data re-recos with the production release.

cc:
@mtosi @connorpa @vbotta

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2020

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_11_1_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
Configuration/StandardSequences
DQMOffline/Alignment

@andrius-k, @kmaeshima, @christopheralanwest, @schneiml, @tocheng, @cmsbuild, @silviodonato, @franzoni, @jfernan2, @fioriNTU, @tlampen, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@pakhotin, @fabiocos, @adewit, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @rovere, @lecriste, @tlampen, @mschrode, @mmusich, @dgulhan, @slomeo, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 28, 2020

@cmsbuild, please test workflow 7.0,7.1,7.2,7.21,7.22,7.23,7.3,7.4

@cmsbuild
Copy link
Contributor

cmsbuild commented May 28, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 02dc9b2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c88a6b/6650/summary.html
CMSSW: CMSSW_11_1_X_2020-05-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c88a6b/6650/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c88a6b/7.1_CosmicsSPLoose+CosmicsSPLoose+DIGICOS+RECOCOS+ALCACOS+HARVESTCOS
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c88a6b/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c88a6b/7.22_Cosmics_UP16+Cosmics_UP16+DIGICOS_UP16+RECOCOS_UP16+ALCACOS_UP16+HARVESTCOS_UP16
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c88a6b/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780792
  • DQMHistoTests: Total failures: 74
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780668
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

+1

@pohsun
Copy link

pohsun commented May 29, 2020

+1

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2020

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2363a05 into cms-sw:CMSSW_11_1_X Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants