add packages used by headers in CondFormats

[davidlange6]

As noted in the modules IB, some package dependencies are missing from the BuildFile. This PR adds them. Changes are to CondFormats/BeamSpotObjects and CondFormats/RecoMuonObjects.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30039/15743

• This PR adds an extra 12KB to repository

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6681/console Started: 2020/05/29 10:08

[cmsbuild]

A new Pull Request was created by @davidlange6 (David Lange) for master.

It involves the following packages:

CondFormats/BeamSpotObjects
CondFormats/RecoMuonObjects

@christopheralanwest, @tocheng, @cmsbuild, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal, @battibass this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Tested at: 3c03f55

CMSSW: CMSSW_11_2_X_2020-05-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Allow DDNames to be created concurrently #29956 @Dr15Jones: Allow DDNames to be created concurrently
• [bugfix] HFNose in TICL - Move template instantiation to .cc #30007 @felicepantaleo: [bugfix] HFNose in TICL - Move template instantiation to .cc
• New O2O for BeamSpot online run start #30000 @ggovi: New O2O for BeamSpot online run start
• Run3-gem38 Correct ME0GeometryBuilder to take care of DDD and DD4HEP #29943 @bsunanda: Run3-gem38 Correct ME0GeometryBuilder to take care of DDD and DD4HEP
• [DD4hep] Expand DDSolidShape and LegacyShape Unit Test #30012 @ianna: [DD4hep] Expand DDSolidShape and LegacyShape Unit Test

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cecbc6/6681/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cecbc6/6681/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cecbc6/6681/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test EcalDCS_O2O_test had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• Allow DDNames to be created concurrently #29956 @Dr15Jones: Allow DDNames to be created concurrently
• [bugfix] HFNose in TICL - Move template instantiation to .cc #30007 @felicepantaleo: [bugfix] HFNose in TICL - Move template instantiation to .cc
• New O2O for BeamSpot online run start #30000 @ggovi: New O2O for BeamSpot online run start
• Run3-gem38 Correct ME0GeometryBuilder to take care of DDD and DD4HEP #29943 @bsunanda: Run3-gem38 Correct ME0GeometryBuilder to take care of DDD and DD4HEP
• [DD4hep] Expand DDSolidShape and LegacyShape Unit Test #30012 @ianna: [DD4hep] Expand DDSolidShape and LegacyShape Unit Test

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cecbc6/6681/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cecbc6/6681/git-merge-result

[cmsbuild]

Comparison job queued.

[davidlange6]

Not related to the changes in this PR .

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cecbc6/6681/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 49
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780693
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[vgvassilev]

Ping

[davidlange6]

@smuzaffar - is this unit test expected to work in pr tests?

[smuzaffar]

No, there is no fix forthis unit test yet ( #30049 )

[davidlange6]

Ok - thanks - then no point in redoing the PR tests.. On Jun 2, 2020, at 2:15 PM, Malik Shahzad Muzaffar <notifications@github.com<mailto:notifications@github.com>> wrote: No, there is no fix forthis unit test yet ( #30049<#30049> ) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#30039 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGPFQ5SHCUZJWLN4XCZZ23RUTUM7ANCNFSM4NNZ6YMA>.

[davidlange6]

@silviodonato - perhaps this can be merged? There is no feedback from those responsible...

[silviodonato]

merge