New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gem39 Modify the ESProducer for GEM/ME0 to work better for ddd/dd4hep #30043
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30043/15748
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30043/15749
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/CSCGeometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@slomeo @watson-ij I @ianna cleaned up the ESProducers of GEM/ME0 and making 2 cff files available so that switching from ddd to dd4hep can be straightforward and in production job the choice of ERA can help. There are still issues with filtered view of dd4hep which gives wrong #'s of nodes in the Expanded view. Also look at the validation cfg's which do not need all the other producers. |
@cmsbuild Please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30043/15757
|
The tests are being triggered in jenkins. |
Pull request #30043 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
@bsunanda Thanks for cleaning this up. |
+1 |
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Modify the ESProducer for GEM/ME0 to work better for ddd/dd4hep
PR validation:
Tested using runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special