Use HGCalRecHitMapProducer

[lecriste]

PR description:

Replace all occurrences of fillHitMap with HGCalRecHitMapProducer and std::map with std::unordered_map in HGCalRecHitMapProducer. No changes are expected in the output.

PR validation:

runTheMatrix -l limited

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30061/15777

• This PR adds an extra 92KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Fireworks/Calo/interface/FWHeatmapProxyBuilderTemplate.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File RecoEgamma/EgammaTools/plugins/HGCalElectronIDValueMapProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File RecoEgamma/EgammaTools/plugins/HGCalPhotonIDValueMapProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File RecoEgamma/EgammaTools/src/EgammaPCAHelper.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
  • File Validation/HGCalValidation/plugins/CaloParticleValidation.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927
  • File Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30061/15777/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30061/15777/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30061/15779

• This PR adds an extra 136KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Fireworks/Calo/interface/FWHeatmapProxyBuilderTemplate.h modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File RecoEgamma/EgammaTools/plugins/HGCalElectronIDValueMapProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File RecoEgamma/EgammaTools/plugins/HGCalPhotonIDValueMapProducer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934
  • File RecoEgamma/EgammaTools/src/EgammaPCAHelper.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File Validation/HGCalValidation/interface/HGVHistoProducerAlgo.h modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933
  • File Validation/HGCalValidation/plugins/CaloParticleValidation.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-for-range-copy #29927
  • File Validation/HGCalValidation/src/HGVHistoProducerAlgo.cc modified in PR(s): [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bd5be0/6906/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780497
• DQMHistoTests: Total failures: 38
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780409
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[jfernan2]

+dqm

[perrotta]

+1

• Replacements and modifications in the code applied as anticipated in the PR description
• With the latest commits finally also decoupled the relevant reconstruction sequence from Validation or Simulation ones
• Timing is roughly untouched wrt previous version of the code in the noPU wf 21234.0
• Jenkins tests pass and show no differences wrt baseline

[kpedro88]

+upgrade

[civanch]

+1

[perrotta]

@alja can you please evaluate and sign for visualization (if you think so)?

[alja]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1