Fix bug affecting boosted tau isolation (11_1_X)

[mbluj]

PR description:

This PR fixes a bug affecting indexing jet-constituent-maps. In the result of the bug constituents of a subjet nearby a considered tau - a seed of a nearby tau candidate - are not excluded from particles used to compute isolation of the tau, which breaks the boosted tau algorithm. The bug has been introduced in #17087 (for 90X) speeding up boosted tau seed producer code. Unfortunately the bug was discovered only recently by users (*).
In addition to the bug fix, in this PR we remove remnants of previous implementation changed by #17087.

Expected changes: boosted taus (in MiniAOD), especially those with other tau candidate within R<0.5, are more isolated. This will recover state from before #17087 as shown in the figure attached to #30064.

Backport of #30064. Some additional details therein.

PR validation:

Tested with the standard miniAOD workflow.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #30064 (using same dev branch thanks to proximity of 11_1_X and 11_2_X)

[cmsbuild]

A new Pull Request was created by @mbluj for CMSSW_11_1_X.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @ahinzmann, @jdamgov, @yslai, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix bug affecting boosted tau isolation #30064

[perrotta]

backport of #30064

[mbluj]

Adding @abdollah110 who found the bug.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6770/console Started: 2020/06/03 15:24

[cmsbuild]

+1
Tested at: 67ebc57
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-921cab/6770/summary.html
CMSSW: CMSSW_11_1_X_2020-06-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-921cab/6770/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 481 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780792
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780740
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[perrotta]

+1

• The fix acts as it should, following the PR description and the intention behind the original code
• The update is identical to the one submitted in the master
• Jenkins tests pass and only show differences in the boosted tau id objects in miniAOD, as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1