Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move EDProducers from Sequences to Tasks in L1T DQM and Validation configurations #30089

Merged
merged 1 commit into from Jun 4, 2020

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Jun 3, 2020

PR description:

This PR fixes an "unrunnable schedule" error in many workflows in CMSSW_11_2_X_2020-06-01-2300

Unrunnable schedule
Module run order problem found: 
L1Reco_step after l1extraParticles [path L1Reco_step], l1extraParticles consumes caloStage1LegacyFormatDigis, caloStage1LegacyFormatDigis after caloStage1Digis [path dqmoffline_step], caloStage1Digis after rctDigis [path dqmoffline_step], rctDigis after l1tGt [path dqmoffline_step], l1tGt after l1tGmt [path dqmoffline_step], l1tGmt after l1tRpctf [path dqmoffline_step], l1tRpctf after l1tCsctf [path dqmoffline_step], l1tCsctf after l1tDttf [path dqmoffline_step], l1tDttf after l1GtUnpack [path dqmoffline_step], l1GtUnpack after dqmProvInfo [path dqmoffline_step], dqmProvInfo after @EndPathStart [path dqmoffline_step], @EndPathStart consumes TriggerResults, TriggerResults consumes L1Reco_step
 Running in the threaded framework would lead to indeterminate results.
 Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.

The problem was that some EDProducer(s) were in a Task in L1Reco step, and put in a Sequence in DQM step. Before the aforementioned IB these EDProducers were moved from Sequence to Task by convertToUnscheduled(), which was removed in #29630, leading to modules associated to a Path to depend on event products produced by producers in EndPath. The proposed fix is to move bunch of non-DQM EDProducers from Seqences to Tasks in L1T DQM and Validation configuration files.

Part of #30074, a second attempt of #30081.

PR validation:

Limited matrix and workflows 134.801,134.802,134.803,134.804,134.805,134.806,134.807,134.808,134.809,134.81,134.811,134.812,134.901,134.902,134.903,134.904,134.905,134.906,134.907,134.908,134.909,134.91,134.911,134.912,134.99601,134.99602,134.99603,134.99901,140.55,145.0 run.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

The code-checks are being triggered in jenkins.

@makortel
Copy link
Contributor Author

makortel commented Jun 3, 2020

type bug-fix

@makortel
Copy link
Contributor Author

makortel commented Jun 3, 2020

urgent

@makortel
Copy link
Contributor Author

makortel commented Jun 3, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30089/15827

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6759/console Started: 2020/06/03 05:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

DQM/L1TMonitor
DQMOffline/L1Trigger
L1Trigger/Configuration
L1Trigger/HardwareValidation

@benkrikler, @kmaeshima, @schneiml, @andrius-k, @cmsbuild, @rekovic, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

+1
Tested at: 5831b7e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f478/6759/summary.html
CMSSW: CMSSW_11_2_X_2020-06-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f478/6759/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2783666
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2783615
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@jfernan2
Copy link
Contributor

jfernan2 commented Jun 3, 2020

+1

@silviodonato
Copy link
Contributor

@rekovic
I'm going to merge this fix in the next IB, if you have no objections.

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 888c58b into cms-sw:master Jun 4, 2020
@makortel makortel deleted the taskL1TMonitor branch June 4, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants