Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the recently updated HI event content #30097

Merged
merged 2 commits into from Jun 6, 2020

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Jun 3, 2020

PR description:

In the restructuring campaign for the reconstruction related event contents, PR #29990 updated the HI ones. In doing so, however, we overlooked the fact that all new event contents started with a "drop *" statement: when more than one of them is put in a row, the "drop *" statement of the second one reset the previous content.

This was noticed in the IB since CMSSW_11_2_X_2020-06-02-2300, and reported in issue #30095.

This PR reports back those event contents which were broken in the previous implementation, and solves that issue.

@jeongeun

PR validation:

Workflows 140.0 and 150.0 now run without errors

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

The code-checks are being triggered in jenkins.

@perrotta
Copy link
Contributor Author

perrotta commented Jun 3, 2020

please test workflow 140,150

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30097/15842

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

A new Pull Request was created by @perrotta for master.

It involves the following packages:

Configuration/EventContent
RecoHI/Configuration

@perrotta, @silviodonato, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@echapon, @MiheeJo, @jazzitup, @fabiocos, @Martin-Grunewald, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Jun 3, 2020

please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

Jenkins tests are aborted.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

The code-checks are being triggered in jenkins.

@perrotta
Copy link
Contributor Author

perrotta commented Jun 3, 2020

please test workflow 140,150
(I realized that the reco config is not the best place where to store the RAW event content... Put it back in EventContentHeavyIons_cff.py, as it was done in origine)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30097/15843

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

Pull request #30097 was updated. @perrotta, @silviodonato, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

+1
Tested at: 597c430
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d16c24/6778/summary.html
CMSSW: CMSSW_11_2_X_2020-06-02-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d16c24/6778/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d16c24/140.0_HydjetQ_B12_5020GeV_2011+HydjetQ_B12_5020GeV_2011+DIGIHI2011+RECOHI2011+HARVESTHI2011

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2783666
  • DQMHistoTests: Total failures: 48
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2783568
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@perrotta
Copy link
Contributor Author

perrotta commented Jun 3, 2020

+1

@silviodonato
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3060253 into cms-sw:master Jun 6, 2020
@perrotta perrotta deleted the fixHiGlobalEventContents branch June 6, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants