New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for the recently updated HI event content #30097
Conversation
The code-checks are being triggered in jenkins. |
please test workflow 140,150 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30097/15842
|
The tests are being triggered in jenkins.
|
A new Pull Request was created by @perrotta for master. It involves the following packages: Configuration/EventContent @perrotta, @silviodonato, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please abort |
Jenkins tests are aborted. |
The code-checks are being triggered in jenkins. |
please test workflow 140,150 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30097/15843
|
The tests are being triggered in jenkins.
|
Pull request #30097 was updated. @perrotta, @silviodonato, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please check and sign again. |
+1 |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1
|
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In the restructuring campaign for the reconstruction related event contents, PR #29990 updated the HI ones. In doing so, however, we overlooked the fact that all new event contents started with a "drop *" statement: when more than one of them is put in a row, the "drop *" statement of the second one reset the previous content.
This was noticed in the IB since CMSSW_11_2_X_2020-06-02-2300, and reported in issue #30095.
This PR reports back those event contents which were broken in the previous implementation, and solves that issue.
@jeongeun
PR validation:
Workflows 140.0 and 150.0 now run without errors