New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move file with similar name L1TMuonEndcapParamsRcd.* #30109
Move file with similar name L1TMuonEndcapParamsRcd.* #30109
Conversation
In the directory is a file with the name L1TMuonEndCapParamsRcd.* where that file is actually used. We can't get rid of the old file as the DB needs that class to exist.
The code-checks are being triggered in jenkins. |
This fixes #17061 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30109/15872
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: CondCore/L1TPlugins @benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
please test |
The tests are being triggered in jenkins. |
Comparison is ready Comparison Summary:
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Do you have any objections? |
@silviodonato we desperately need this change to be applied. It is needed to allow checkout to Windows or Mac computers. The lack of applying this pull requiest is now causing us serious problems. |
+1 @ggovi, Could you review this for db? |
merge |
+1 |
PR description:
In the directory is a file with the name L1TMuonEndCapParamsRcd.* where that file is actually used. We can't get rid of the old file as the DB needs that class to exist.
PR validation:
The code and all code dependent upon the file compiles.