Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move file with similar name L1TMuonEndcapParamsRcd.* #30109

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

In the directory is a file with the name L1TMuonEndCapParamsRcd.* where that file is actually used. We can't get rid of the old file as the DB needs that class to exist.

PR validation:

The code and all code dependent upon the file compiles.

In the directory is a file with the name L1TMuonEndCapParamsRcd.*
where that file is actually used. We can't get rid of the old
file as the DB needs that class to exist.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

The code-checks are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

This fixes #17061

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30109/15872

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondCore/L1TPlugins
CondFormats/DataRecord

@benkrikler, @christopheralanwest, @tocheng, @cmsbuild, @rekovic, @tlampen, @ggovi, @pohsun can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6819/console Started: 2020/06/04 18:39

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

+1
Tested at: bc66bb9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-155b12/6819/summary.html
CMSSW: CMSSW_11_2_X_2020-06-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

Comparison job queued.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6827/console Started: 2020/06/04 21:01

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-155b12/6819/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2783960
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2783880
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

+1
Tested at: bc66bb9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-155b12/6827/summary.html
CMSSW: CMSSW_11_2_X_2020-06-04-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-155b12/6827/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2783960
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2783880
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@silviodonato
Copy link
Contributor

Do you have any objections?
alca: @pohsun @tlampen @tocheng @christopheralanwest
l1: @benkrikler @rekovic
db: @ggovi

@Dr15Jones
Copy link
Contributor Author

@silviodonato we desperately need this change to be applied. It is needed to allow checkout to Windows or Mac computers. The lack of applying this pull requiest is now causing us serious problems.

@christopheralanwest
Copy link
Contributor

+1

@ggovi, Could you review this for db?

@silviodonato
Copy link
Contributor

merge
l1: @benkrikler @rekovic
db: @ggovi

@cmsbuild cmsbuild merged commit a89f2b2 into cms-sw:master Jun 19, 2020
@ggovi
Copy link
Contributor

ggovi commented Jun 19, 2020

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants