Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make nominalValue() inlined #3012

Merged
merged 1 commit into from Mar 29, 2014
Merged

make nominalValue() inlined #3012

merged 1 commit into from Mar 29, 2014

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Mar 25, 2014

restore performance critical method as inlined (the optimization barrier remains)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_1_X.

make nominalValue() inlined

It involves the following packages:

MagneticField/Engine

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 28, 2014

checking

@slava77
Copy link
Contributor

slava77 commented Mar 29, 2014

+1

for #3012 1c80ad7
tested in CMSSW_7_1_X_2014-03-25-1400 (my test area sign329)
no diffs as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request Mar 29, 2014
Reco -- make nominalValue() inlined
@ktf ktf merged commit 19ba3ad into cms-sw:CMSSW_7_1_X Mar 29, 2014
@VinInn VinInn deleted the MagFieldInlined branch July 13, 2016 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants