Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DD4hep] Allow Assembly Registration in the Namespace #30135

Merged
merged 2 commits into from Jun 10, 2020
Merged

[DD4hep] Allow Assembly Registration in the Namespace #30135

merged 2 commits into from Jun 10, 2020

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jun 7, 2020

PR description:

  • Assembly can be registered in and accessed from a Namespace
  • DDEcalPreshowerAlgorithm is updated to use Assemblies
    • All overlaps removed
    • Numerous complicated Boolean shapes removed
    • Air volumes replaced with Assemblies
    • The algorithm code base reduces by half

Before: Overlaps of the sensitive volumes with their mother volume:
Screenshot 2020-06-07 at 15 39 02
The old Boolean shape that is replaced by an Assembly:
Screenshot 2020-06-07 at 16 11 20

After: Sensitive detector elements and 0 overlaps:
Screenshot 2020-06-07 at 15 04 26

@bsunanda - please, comment

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Jun 7, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30135/15919

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Configuration/Geometry
DetectorDescription/DDCMS
Geometry/CMSCommonData
Geometry/DTGeometryBuilder
Geometry/EcalCommonData
Geometry/HcalAlgo
Geometry/MuonCommonData
Geometry/TrackerCommonData
Geometry/TrackerGeometryBuilder
MagneticField/GeomBuilder
SimG4Core/DD4hepGeometry

@perrotta, @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@namapane, @battibass, @rchatter, @vargasa, @rovere, @argiro, @Martin-Grunewald, @makortel, @VinInn, @ptcox, @ebrondol, @ghugo83, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Jun 7, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6864/console Started: 2020/06/07 17:53

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

-1

Tested at: 904d604

CMSSW: CMSSW_11_2_X_2020-06-07-0000
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-def7f6/6864/summary.html

I found follow errors while testing this PR

Failed tests: ClangBuild

  • Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2020

Comparison not run due to Build errors/Fireworks only changes/No short matrix requested (RelVals and Igprof tests were also skipped)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

The code-checks are being triggered in jenkins.

@ianna
Copy link
Contributor Author

ianna commented Jun 9, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30135/15950

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6899/console Started: 2020/06/09 13:45

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

Pull request #30135 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

+1
Tested at: 75be817
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-def7f6/6899/summary.html
CMSSW: CMSSW_11_2_X_2020-06-09-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-def7f6/6899/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2780497
  • DQMHistoTests: Total failures: 50
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2780397
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 9, 2020

@ianna What happened to this PR? The description says it replaces preshower algorithms, but there is only a deletion, no replacement.

@ianna
Copy link
Contributor Author

ianna commented Jun 9, 2020

#30135 (comment)

There are a few lines changed and due to that the rest of the code is not needed - hence deleted 😀

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 9, 2020

@ianna OK, I understand now. I saw some of these files in other your other PRs, so I was confused as to which one they belong to.

@cvuosalo
Copy link
Contributor

cvuosalo commented Jun 9, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3cff852 into cms-sw:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed geometry-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ianna @cmsbuild @slava77 @smuzaffar @makortel @cvuosalo @silviodonato